Fix stacked crafting ingredient consumption - #2013
Open
cryptnetworks wants to merge 1 commit into
Open
Conversation
cryptnetworks
marked this pull request as ready for review
August 5, 2026 01:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The 1.12.x project bench crafting helper always removed exactly one item for every occupied crafting slot. Modded recipes can require larger per-slot stack sizes; IC2 Classic's plasma core recipe, for example, requires two magnets or four advanced alloys in its respective slots. ProjectRed would produce the output while under-consuming those ingredients, causing the duplication reported in xJon/Tekkit-2#266.
The new lookup still resolves to one item for vanilla-style recipes, while count-sensitive recipes consume the smallest stack size that continues to match and produces the same output. Candidate item substitutions remain subject to the existing recipe and output checks.
Validation
./gradlew compileScala --no-daemonwith Temurin JDK 8./gradlew build --no-daemonwith Temurin JDK 8git diff --checkRelated: xJon/Tekkit-2#266