Skip to content

Add MSVC 2022 builds to CI - #331

Closed
AnyOldName3 wants to merge 1 commit into
MyGUI:masterfrom
AnyOldName3:msvc-2022-in-ci
Closed

AnyOldName3 wants to merge 1 commit into
MyGUI:masterfrom
AnyOldName3:msvc-2022-in-ci

Conversation

@AnyOldName3

Copy link
Copy Markdown
Contributor

This should stop other build failures sneaking through. Helpfully, the windows-latest image has multiple versions of the MSVC compiler installed, and CMake can pick one based on the -T argument.

OpenMW still supports MSVC 2022
@AnyOldName3

Copy link
Copy Markdown
Contributor Author

This is still failing to build with errors like:

C:\openmw-dev\mygui\UnitTests\UnitTest_Delegates\Main.cpp(32,59): error C2248: 'MyGUI::delegates::detail::DelegateBase::clear': cannot access protected member declared in class 'MyGUI::delegates::detail::DelegateBase' [C:\openmw-dev\mygui\build-GL\UnitTests\U
nitTest_Delegates\UnitTest_Delegates.vcxproj]
  (compiling source file '../../../UnitTests/UnitTest_Delegates/Main.cpp')
      C:\openmw-dev\mygui\MyGUIEngine\include\MyGUI_Delegate.h(125,10):
      see declaration of 'MyGUI::delegates::detail::DelegateBase::clear'
      C:\openmw-dev\mygui\MyGUIEngine\include\MyGUI_Delegate.h(98,10):
      see declaration of 'MyGUI::delegates::detail::DelegateBase'

MyGUI::delegates::detail::DelegateBase::clear and MyGUI::delegates::detail::DelegateBase::empty do indeed appear to be protected members referred to outside of where they'd be accessible. It builds just fine if those two members are made public.

@Altren

Altren commented Oct 21, 2026

Copy link
Copy Markdown
Member

I'll handle both issues, one is clear compiler bug, another is correct warning, but I'm surprised that it is gone in MSVC 2026

@Altren

Altren commented Oct 21, 2026

Copy link
Copy Markdown
Member

Fixes and CI merged into master

@Altren Altren closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants