Fixes for fire perimeter - #7
Merged
Merged
Conversation
* Goes back to previous ENO1 * Pseudo time coef default is 0.0001
21 tasks
pedro-jm
approved these changes
Jun 24, 2026
|
Testing completed successfully for ufs-community/ufs-weather-model#3267. @pedro-jm This PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the most recent version of the UFS fire behavior code has shown some unexpected results. The default case in the SRW Application prior to the latest changes (ufs-community/ufs-srweather-app#1376) showed reasonable results. However, after those changes, the fire perimeter after 6 hours showed some anomalies:
After 16 hours the simulation was completely unrealistic:
And the simulation stopped after ~18 hours due to the fire reaching the boundary.
The fixes are as follows:
reinit_pseudot_coef) to its previous default value of 0.0001. This resulted in an improvement but still anomalous results:After these changes, the results at long lead times again look realistic: