fix(policy): harden landlock.compatibility validation - #2541
Open
letv1nnn wants to merge 2 commits into
Open
Conversation
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
…ystem paths Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
letv1nnn
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 29, 2026 13:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
best_effort. Fixed by parsing into an enum at YAML parse time andTryFromimplementation at the proto conversion layer.hard_requirementwith no filesystem paths configured was a silent no-op, Landlock skipped entirely. Fixed by erroring before the early return whenhard_requirementis set and both path lists are empty.Related Issue
closes #2356
Changes
Two fixes to
landlock.compatibilityenforcement. Invalid values now fail at YAML parse time instead of silently falling back tobest_effort. Configuringhard_requirementwith no filesystem paths now aborts sandbox startup instead of skipping Landlock entirely. Docs updated to reflect the new behavior.Testing
mise run pre-commitpassesChecklist