fix: simplify redundant softmax version condition - #3363
Open
andrewwhitecdw wants to merge 1 commit into
Open
Conversation
Squashed to single commit for review. Original PR: #15
Contributor
Greptile SummaryThis PR simplifies a redundant cuDNN-version condition without changing fused-attention backend selection behavior.
Confidence Score: 5/5The PR appears safe to merge because the simplified predicate is equivalent to the original for all version and softmax-type combinations. The change removes a redundant comparison while preserving the exact set of inputs that select the fused-attention backend. Important Files Changed
Reviews (1): Last reviewed commit: "fix: simplify redundant softmax version ..." | Re-trigger Greptile |
cyanguwa
approved these changes
Aug 13, 2026
Collaborator
|
Please fix the DCO for this PR. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
transformer_engine/common/fused_attn/fused_attn.cpp: simplify redundant softmax version condition.Changes
transformer_engine/common/fused_attn/fused_attn.cpp: simplify redundant softmax version condition.Details
Tests