Skip to content

fix: typo and unnecessary f-string in BRCM skip message - #3370

Merged
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-fused-attn-typo-and-unnecessary-f-string-in-brcm
Aug 13, 2026
Merged

fix: typo and unnecessary f-string in BRCM skip message#3370
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-fused-attn-typo-and-unnecessary-f-string-in-brcm

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR fixes a typo in tests/jax/test_fused_attn.py: typo and unnecessary f-string in BRCM skip message.

Changes

  • tests/jax/test_fused_attn.py: typo and unnecessary f-string in BRCM skip message.

Details

--- a/tests/jax/test_fused_attn.py
+++ b/tests/jax/test_fused_attn.py
@@ -1,1 +1,1 @@
-                pytest.skip(f"cuDNN does not support non-zero dropoouts for BRCM")
+                pytest.skip("cuDNN does not support non-zero dropouts for BRCM")

Tests

Let me know if you want tests added for this fix or not.

@github-actions github-actions Bot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Aug 13, 2026
@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR corrects the “dropouts” typo in the BRCM skip message and removes unnecessary f-string prefixes from three static skip messages.

  • Corrects the non-zero dropout skip message.
  • Simplifies static BRCM skip-message literals.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
tests/jax/test_fused_attn.py Corrects a typo and replaces three interpolation-free f-strings with ordinary string literals without changing test behavior.

Reviews (2): Last reviewed commit: "fix: typo and unnecessary f-string in BR..." | Re-trigger Greptile

@cyanguwa cyanguwa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch, but for consistency, we could remove the f-string for all the pytest.skips above this line as well. Thanks.

Squashed to single commit for review.

Original PR: #8

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@andrewwhitecdw
andrewwhitecdw force-pushed the codequality/test-fused-attn-typo-and-unnecessary-f-string-in-brcm branch from 473dbe3 to 7c1cbfd Compare August 13, 2026 16:57
@andrewwhitecdw

Copy link
Copy Markdown
Contributor Author

Thanks @cyanguwa! I removed the unnecessary f-strings from the other pytest.skip calls above that line too (the BRCM cross-attn and pre/post scale bias messages) for consistency.

@cyanguwa
cyanguwa merged commit c280e7c into NVIDIA:main Aug 13, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants