Skip to content

fix: allgather striped window_size (5,0) id says (8,0) - #3374

Merged
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/test-distributed-fused-attn-allgather-striped-window-size-5-0-id
Aug 13, 2026
Merged

fix: allgather striped window_size (5,0) id says (8,0)#3374
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/test-distributed-fused-attn-allgather-striped-window-size-5-0-id

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR addresses the following issue in tests/jax/test_distributed_fused_attn.py: allgather striped window_size (5,0) id says (8,0).

Changes

  • tests/jax/test_distributed_fused_attn.py: allgather striped window_size (5,0) id says (8,0).

Details

--- a/tests/jax/test_distributed_fused_attn.py
+++ b/tests/jax/test_distributed_fused_attn.py
@@ -1,7 +1,7 @@
-    @pytest.mark.parametrize(
-        "window_size",
-        [
-            pytest.param((-1, -1), id="window_size(-1, -1)"),
-            pytest.param((5, 0), id="window_size(8, 0)"),
-        ],
-    )
+    @pytest.mark.parametrize(
+        "window_size",
+        [
+            pytest.param((-1, -1), id="window_size(-1, -1)"),
+            pytest.param((5, 0), id="window_size(5, 0)"),
+        ],
+    )

Tests

Let me know if you want tests added for this fix or not.

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@github-actions github-actions Bot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Aug 13, 2026
@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Corrects the pytest identifier for the striped all-gather fused-attention case so the displayed window size matches the actual (5, 0) parameter.

  • Changes only the test-case display identifier.
  • Leaves the parameter value and test behavior unchanged.

Confidence Score: 5/5

The PR appears safe to merge because it only corrects test-reporting metadata to match the existing parameter value.

The changed pytest ID now accurately describes the (5, 0) input, with no effect on test selection, inputs, assertions, or runtime behavior.

Important Files Changed

Filename Overview
tests/jax/test_distributed_fused_attn.py Correctly updates a mismatched pytest parameter ID from window_size(8, 0) to window_size(5, 0) without changing test execution.

Reviews (1): Last reviewed commit: "fix: allgather striped window_size (5,0)..." | Re-trigger Greptile

@cyanguwa
cyanguwa merged commit 67c26e2 into NVIDIA:main Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants