fix: allgather striped window_size (5,0) id says (8,0) - #3374
Merged
Conversation
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
Contributor
Greptile SummaryCorrects the pytest identifier for the striped all-gather fused-attention case so the displayed window size matches the actual
Confidence Score: 5/5The PR appears safe to merge because it only corrects test-reporting metadata to match the existing parameter value. The changed pytest ID now accurately describes the Important Files Changed
Reviews (1): Last reviewed commit: "fix: allgather striped window_size (5,0)..." | Re-trigger Greptile |
cyanguwa
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
tests/jax/test_distributed_fused_attn.py: allgather striped window_size (5,0) id says (8,0).Changes
tests/jax/test_distributed_fused_attn.py: allgather striped window_size (5,0) id says (8,0).Details
Tests