fix: L0 placeholder shapes are invalid empty tuple/list - #3375
Open
andrewwhitecdw wants to merge 1 commit into
Open
Conversation
Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
Contributor
Greptile SummaryThis PR replaces invalid L0 placeholder shapes with empty parameter collections and adds a regression test enforcing that representation.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The empty L0 collections follow the existing parametrization convention, L0 CI does not invoke this distributed test file, and the L1/L2 jobs continue to use valid nonempty shape sets. Important Files Changed
Reviews (1): Last reviewed commit: "fix: L0 placeholder shapes are invalid e..." | Re-trigger Greptile |
cyanguwa
reviewed
Aug 13, 2026
| assert jnp.array_equal(inversed, ref) | ||
|
|
||
|
|
||
| def test_l0_shape_placeholders_are_empty(): |
Collaborator
There was a problem hiding this comment.
I think the test is not really necessary - could you please remove it? Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue in
tests/jax/test_distributed_fused_attn.py: L0 placeholder shapes are invalid empty tuple/list.Changes
tests/jax/test_distributed_fused_attn.py: L0 placeholder shapes are invalid empty tuple/list.Details
Tests
tests/jax/test_distributed_fused_attn.py