Skip to content

fix: remove redundant second export of XLA_FLAGS in L0 - #3377

Merged
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-remove-redundant-second-export-of-xla
Aug 13, 2026
Merged

fix: remove redundant second export of XLA_FLAGS in L0#3377
cyanguwa merged 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-remove-redundant-second-export-of-xla

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR fixes a script issue in qa/L0_jax_unittest/test.sh: remove redundant second export of XLA_FLAGS in L0.

Changes

  • qa/L0_jax_unittest/test.sh: remove redundant second export of XLA_FLAGS in L0.

Details

--- a/qa/L0_jax_unittest/test.sh
+++ b/qa/L0_jax_unittest/test.sh
@@ -1,3 +1,2 @@
-# Test without custom calls
-export XLA_FLAGS="${XLA_FLAGS} --xla_gpu_deterministic_ops"
-NVTE_JAX_CUSTOM_CALLS="false" python3 -m pytest -c $TE_PATH/tests/jax/pytest.ini -v --junitxml=$XML_LOG_DIR/pytest_test_single_gpu_encoder_without_custom_call.xml $TE_PATH/examples/jax/encoder/test_single_gpu_encoder.py || test_fail "test_single_gpu_encoder.py without custom calls"
+# Test without custom calls
+NVTE_JAX_CUSTOM_CALLS="false" python3 -m pytest -c $TE_PATH/tests/jax/pytest.ini -v --junitxml=$XML_LOG_DIR/pytest_test_single_gpu_encoder_without_custom_call.xml $TE_PATH/examples/jax/encoder/test_single_gpu_encoder.py || test_fail "test_single_gpu_encoder.py without custom calls"

Tests

Let me know if you want tests added for this fix or not.

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@github-actions github-actions Bot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Aug 13, 2026
@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes a redundant XLA_FLAGS export from the JAX L0 test script. The existing export remains active for both encoder test invocations, while the deterministic-ops flag is no longer appended twice.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The first XLA_FLAGS export remains in the same shell process and therefore still applies to both pytest invocations; removing the second export only prevents duplicating the same flag.

Important Files Changed

Filename Overview
qa/L0_jax_unittest/test.sh Removes the duplicate deterministic-ops flag export without changing the environment inherited by either test invocation.

Reviews (1): Last reviewed commit: "fix: remove redundant second export of X..." | Re-trigger Greptile

@cyanguwa
cyanguwa merged commit 910be8b into NVIDIA:main Aug 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants