[Pytorch] Optimize CPU overhead for NCCL EP eager mode - #3378
Open
YangFei1990 wants to merge 2 commits into
Open
[Pytorch] Optimize CPU overhead for NCCL EP eager mode#3378YangFei1990 wants to merge 2 commits into
YangFei1990 wants to merge 2 commits into
Conversation
Signed-off-by: YangFei1990 <feiw@nvidia.com>
YangFei1990
marked this pull request as ready for review
August 13, 2026 21:51
Collaborator
Author
|
/te-ci L1 pytorch |
Contributor
Greptile SummaryThis PR reduces eager-mode expert-parallel receive-count readback overhead by having the prepare operation write directly into pinned host memory.
Confidence Score: 5/5The PR appears safe to merge with no actionable changed-code failures identified. The eager path preserves the required producer-before-host-read ordering while avoiding a pageable device-to-host transfer, and the non-eager graph path retains its device-resident counter. Important Files Changed
Reviews (1): Last reviewed commit: "Merge branch 'main' into ncclep_cpu_over..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce NCCL EP CPU overhead by using pinned memory CPU tensor.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: