[WIP] Fix batched silhouette score reduction aliasing - #2422
Draft
csadorf wants to merge 4 commits into
Draft
Conversation
csadorf
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test f8c9939 |
csadorf
force-pushed
the
fix-batched-silhouette-reduction-aliasing
branch
from
August 6, 2026 18:08
f8c9939 to
6ec7aeb
Compare
Contributor
Author
|
/ok to test 6ec7aeb |
csadorf
changed the title
Contributor
Author
|
/ok to test 6ec7aeb |
csadorf
force-pushed
the
fix-batched-silhouette-reduction-aliasing
branch
from
August 7, 2026 14:57
6ec7aeb to
d24aff2
Compare
Contributor
Author
|
/ok to test d24aff2 |
csadorf
force-pushed
the
fix-batched-silhouette-reduction-aliasing
branch
from
August 7, 2026 15:48
d24aff2 to
77aaa23
Compare
Contributor
Author
|
/ok to test 77aaa23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stores the row-wise minimum for batched silhouette scores in a separate device vector, preventing the reduction output from overwriting matrix elements that may still be read.