Repository navigation
Open an organization's screen from a link to it, as the web does - #152
Merged
simonhamp merged 1 commit intoNov 3, 2026
Merged
Conversation
Member
|
lovely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a link to an organization like
https://dev-null.sh/@dev-null-shopens the profile screen and fails withNo query results for model [App\Models\User] dev-null-shsinceGET /api/v1/users/dev-null-shis a 404 whileGET /api/v1/organizations/dev-null-shanswersthe web doesn't hit it because
routes/web.phptries an organization when no user has the handlea link can't tell a user from an organization so the app does the same now
when the profile screen gets a 404 before devnull has sent it anything for that handle it replaces itself with
{tab}/organizations/{handle}in the same tabSiteLinkand an organization's name on a notification it sentnew tests in
ProfileTestcover a link and a notification opening the organization screen and a profile staying put when a thread on it is gonethey fail without the fix or without its guards and the full suite passes
Screenshots
the iOS simulator against
dev-null.shopeningdevnull://log/users/dev-null-shwhich is whereSiteLinksendshttps://dev-null.sh/@dev-null-shorg-link
Android isn't here since I don't have the app signed in on an emulator against
dev-null.sh