Skip to content

Even out the commit action row, full-width hairlines, fixed logo size - #80

Open
shanerbaner82 wants to merge 2 commits into
mainfrom
polish/commit-row-and-logo
Open

shanerbaner82 wants to merge 2 commits into
mainfrom
polish/commit-row-and-logo

Conversation

@shanerbaner82

Copy link
Copy Markdown

What

  • Action row: star, pastel, Quote and Reply share the row's width equally, like X, each at least 44pt wide and 36pt tall. Reply is an icon, as the others are. More stays at the right edge.
  • Hairlines: the line under a commit now runs the full width, under the rail's gutter too. The rail gutter is left padding instead of a margin. Under a thread the line is the last reply's own row border instead of a separate element inside the text column.
  • Logo: the nav bar logo has an explicit 105x28 size. On device it pulsed from tiny to full size on a loop without one. This is a guess at the cause, so check it on device.

Verified

Pest passes (1188 tests, arch test excluded: it runs out of PHP's default memory). Checked on an iPhone 15 Pro Max from a screen recording; the action row and hairline changes looked right, and the logo fix was confirmed there too.

Not in this PR

App Store Connect lists the in-flight version as 1.0 with bundle ID com.nativephp.devnull. Those are set on the Bifrost side, not in the repo.

🤖 Generated with Claude Code

…the logo size

The star, pastel, Quote and Reply actions now share the row equally, X-style, with Reply as an icon like the rest. The hairline under a commit takes the rail's gutter as padding, and under a thread it's the last reply's own border, so both run the row's full width. The nav bar logo gets an explicit 105x28 size, as it pulsed in and out on device without one.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…n it

Share was the first item of More. It's now a button of its own at the end of the row, like X's, and More keeps Pin, Report and Delete, and isn't drawn when there are none, such as on someone else's commit that isn't approved yet.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant