feat: RN TurboModule -- threading + Fabric integration, rebuilt (supersedes #46) - #72
Open
DjDeveloperr wants to merge 1 commit into
Open
feat: RN TurboModule -- threading + Fabric integration, rebuilt (supersedes #46)#72DjDeveloperr wants to merge 1 commit into
DjDeveloperr wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DjDeveloperr
added a commit
that referenced
this pull request
Aug 20, 2026
Matches @nativescript/react-native's existing peerDependenciesMeta convention. Without it, npm's auto-peer-install for @nativescript/react-native-screens pulled in react-native-worklets@0.11.4 (peer react-native 0.83-0.86), conflicting with the workspace's real react-native@0.79.5 (pinned transitively via react-native-node-api) and breaking `npm install` at the repo root -- this is what CI's build job runs, and it failed on PR #72 for exactly this reason.
DjDeveloperr
added a commit
that referenced
this pull request
Aug 20, 2026
Matches @nativescript/react-native's existing peerDependenciesMeta convention. Without it, npm's auto-peer-install for @nativescript/react-native-screens pulled in react-native-worklets@0.11.4 (peer react-native 0.83-0.86), conflicting with the workspace's real react-native@0.79.5 (pinned transitively via react-native-node-api) and breaking `npm install` at the repo root -- this is what CI's build job runs, and it failed on PR #72 for exactly this reason.
DjDeveloperr
force-pushed
the
rn-turbomodule
branch
3 times, most recently
from
August 22, 2026 20:05
39d1565 to
e76dea6
Compare
DjDeveloperr
force-pushed
the
rn-turbomodule
branch
from
August 23, 2026 06:39
e76dea6 to
aa79c4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilds the React Native TurboModule and Fabric integration around generic native-component contracts. The runtime now exposes one component definition API for native view creation, props, events, commands, layout, child mounting, controller containment, and teardown.
Architecture
defineNativeComponentowns the typed JavaScript contract. Fabric delegates native lifecycle hooks to the UI runtime, while the Objective-C++ layer handles mounting transactions, layout metrics, events, commands, controller ownership, and runtime invalidation. Component implementations remain outside the runtime package.The old specialized UIKit host surface and its process-wide view swizzling are removed. This also removes the legacy registries, batch walkers, point-fix RPCs, frame-loop hook, and specialized controller/view APIs.
Verification
Known limitation
Completion blocks declared only by Objective-C protocols still require an explicit
interop.Blocksignature until #71 lands. Class-declared completion parameters accept ordinary closures.