Repository navigation
setup.sh: fail fast with a clear message on non-x86_64 (ARM) before downloading - #3557
Open
hernandez42 wants to merge 1 commit into
Open
hernandez42 wants to merge 1 commit into
hernandez42 wants to merge 1 commit into
Conversation
|
Thanks for the pull request. To keep the tracker readable, every item needs an area prefix in the title and the parts of the pull request template filled in. This one is missing:
Edit the pull request (title and description) and this note goes away on its own. If it is still missing parts in 5 days it will be closed, which is not a rejection: fix it and comment Details: CONTRIBUTING.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a fail-fast architecture guard at the top of setup.sh so non-x86_64 machines (NVIDIA Jetson/AGX Xavier, Raspberry Pi, Apple Silicon Linux) get a clear message BEFORE downloading gigabytes of engine + CUDA/HIP wheels and crashing mid-install. Today setup.py only checks x64 via an x86_64-only CPUID stub, so ARM users find out the toolchain is x86_64-only too late.
Why
Strata has no aarch64 build path (all prebuilt engine assets and NVIDIA/AMD wheels are x86_64; aarch64:0 and arm64:0 in setup.py; gpus()/CPUID assume x86_64). This guard turns the confusing late failure into an immediate, actionable message pointing to docs/OLDER_GPUS.md.
Change
POSIX-sh block after cd "$(dirname "$0")":
if [ "$(uname -m)" != "x86_64" ]; then
echo "[X] Strata currently supports x86_64 only (this machine is $(uname -m))."
echo " Prebuilt engine and NVIDIA/AMD wheels are x86_64-only; no aarch64 path yet."
echo " Supported NVIDIA: RTX 20/30/40/50 (older Pascal/Volta via experimental CUDA-12, docs/OLDER_GPUS.md)."
exit 1
fi
Behavior on supported platforms is unchanged.
Test
x86_64 passes; aarch64 prints clear error and exits 1 before any download. Happy to move the check into setup.py if maintainers prefer.