Skip to content

setup.sh: fail fast with a clear message on non-x86_64 (ARM) before downloading - #3557

Open
hernandez42 wants to merge 1 commit into
Niko1221:mainfrom
hernandez42:feat/arm-arch-guard
Open

hernandez42 wants to merge 1 commit into
Niko1221:mainfrom
hernandez42:feat/arm-arch-guard

Conversation

@hernandez42

Copy link
Copy Markdown

What

Add a fail-fast architecture guard at the top of setup.sh so non-x86_64 machines (NVIDIA Jetson/AGX Xavier, Raspberry Pi, Apple Silicon Linux) get a clear message BEFORE downloading gigabytes of engine + CUDA/HIP wheels and crashing mid-install. Today setup.py only checks x64 via an x86_64-only CPUID stub, so ARM users find out the toolchain is x86_64-only too late.

Why

Strata has no aarch64 build path (all prebuilt engine assets and NVIDIA/AMD wheels are x86_64; aarch64:0 and arm64:0 in setup.py; gpus()/CPUID assume x86_64). This guard turns the confusing late failure into an immediate, actionable message pointing to docs/OLDER_GPUS.md.

Change

POSIX-sh block after cd "$(dirname "$0")":
if [ "$(uname -m)" != "x86_64" ]; then
echo "[X] Strata currently supports x86_64 only (this machine is $(uname -m))."
echo " Prebuilt engine and NVIDIA/AMD wheels are x86_64-only; no aarch64 path yet."
echo " Supported NVIDIA: RTX 20/30/40/50 (older Pascal/Volta via experimental CUDA-12, docs/OLDER_GPUS.md)."
exit 1
fi
Behavior on supported platforms is unchanged.

Test

x86_64 passes; aarch64 prints clear error and exits 1 before any download. Happy to move the check into setup.py if maintainers prefer.

@github-actions github-actions Bot added the needs-format Title or template does not follow CONTRIBUTING.md yet label Oct 21, 2026
@github-actions

Copy link
Copy Markdown

Thanks for the pull request. To keep the tracker readable, every item needs an area prefix in the title and the parts of the pull request template filled in. This one is missing:

  • Start the title with its area: [Engine], [GUI], [TUI], [Benchmark], [Docs] or [Other], then a short description. Example: "[Engine] fix decode stop on long prompts".
  • Fill in "Problem and result": what triggered the change, and how it behaves before and after.

Edit the pull request (title and description) and this note goes away on its own. If it is still missing parts in 5 days it will be closed, which is not a rejection: fix it and comment /reopen.

Details: CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-format Title or template does not follow CONTRIBUTING.md yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant