Remove event-triggered Type label reminders to fix race condition on issue creation#14993
Conversation
| then: | ||
| - removeLabel: | ||
| label: missing-required-type | ||
| - description: '[20-30] Remind NuGet Client member (issue author) to add Type label' |
There was a problem hiding this comment.
@copilot You were supposed toc hange this to a scheduled search.
There was a problem hiding this comment.
Done. [20-30] is now a daily scheduled search (scheduledSearches) with the same Type-label guards and the @${issueAuthor} mention. The isNotLabeledWith: missing-required-type guard ensures it only fires once per issue (same dedup mechanism as [20-10]).
[20-40] (assignee notification) was omitted — it triggered on Reopened/Assigned/Closed events where ${assignees} has meaningful context, but as a scheduled search there is no equivalent filter to target only assigned issues or to avoid pinging empty assignee lists daily.
| reply: Issue is missing Type label, remember to add a [Type label](https://github.com/NuGet/Client.Engineering/blob/main/designs/nuget-issues-approach.md#issue-type) | ||
| - addLabel: | ||
| label: missing-required-type | ||
| - description: '[20-30] Remind NuGet Client member (issue author) to add Type label' |
There was a problem hiding this comment.
This is really just about issue author isn't it?
Not client team member.
Isn't this duplicating [20-10] ?
When an issue is created with a Type label via the GitHub web UI, the
Openedwebhook fires before the label events arrive. Tasks [20-30] and [20-40] evaluated label state against this incomplete payload, causingmissing-required-typeand a false-positive reminder comment to be added to correctly-labeled issues — with no automatic cleanup path.Changes
Openedto remind issue authors to add a Type labelReopened/Assigned/Closedto remind assignees to add a Type labelmissing-required-typewhen a Type label is later applied