Re-style the right-hand article navigation panel - #3318
Conversation
| import { accelerator } from '@lib/accelerator'; | ||
| import { SITE } from '@config'; | ||
| import { Translations, Lang } from '@util/Languages'; | ||
| import Separator from './Separator.astro'; |
There was a problem hiding this comment.
Yeah looks like it's unused except for the components demo page.
I think I'd prefer to leave it though, in case we need to put it back for some reason, and file a card to clean it up at the end, if that's OK?
There was a problem hiding this comment.
Actually, given that the spelling error caused me to need to re-spin the PR, I deleted the component.
Claude keeps writing comments in the CSS which say "colour" but our spelling requires AMERICAN :-(
|
Pull request environment is available at https://stoctodocspr3318.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
|
Looks all good overall, would be happy with merge, one thing i did notice is we have lost toe header highlighted when its expanded and the hover affect like the original, also the carat is facing right when its collapsed instead of down saying, click to pull the menu down, all trivial.
can see here, side by side view (zoom in on both to trigger the responsive view.) Oh and there is also a c-spell error |
I'm not sure what this means?
I didn't realize that the article nav event did anything in the mobile layout! Upon seeing it though, the change is intentional; In the figma it states for the nav that unexpanded sections should have a rightward-facing arrow. Down means expanded. The previous behaviour was wrong. Good job claude |
|
Very nice @borland 👏🏻 I have two hopefully small bits of feedback:
CleanShot.2026-08-07.at.15.26.18.mp4 |
enf0rc3
left a comment
There was a problem hiding this comment.
Happy with this, did in person review found the UI is consistent with best practice.
Ellen did point out two minor things i would implement, smooth transition animation of the sidebar, now she mentions it it does look choppy.
Also the 80px, that could be considered apart of layout, but may as well do it now.
Feel free to merge those above changes without re-review
5dc1ea5 to
85f0adf
Compare
|
Hey @ellen-octopus - I got claude to make those suggested changes. The position indicator in the right-nav now animates smoothly, and the right-nav now anchors 80px to the right of the content column. An additional change I made was that the content column and right-nav are now centered together as a group., so the actual content is slightly left of center. Claude offered this as a suggestion, and I took it, because that's what Linear's docs do, and seeing it in action, it's a lot nicer now that the nav is anchored to the content. I'll merge this in the interests of unblocking @enf0rc3, who has other changes that rely on the right-nav waiting in the wings. |
…s comment # Conflicts: # src/pages/components.mdx Separator component is gone
…d center them both together. Article nav position indicator now animates smoothly
85f0adf to
8632b76
Compare
Thanks @borland 🙌🏻 that was the intention, so that works out perfectly. Thanks so much, it looks fantastic 🎉 |



Results
Claude does all the coding here; I reviewed and re-steered it several times to improve things.
Before
After
Testing
Tested on macOS in MS Edge (chrome), Safari and Firefox