Remove "Shared marketing footer" and build docs specific one as per design - #3320
Conversation
118f015 to
887d048
Compare
|
Pull request environment is available at https://stoctodocspr3320.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
enf0rc3
changed the title
| "dev": "npm-run-all --parallel dev:img dev:dictionary dev:astro dev:watch", | ||
| "dev:dictionary": "node ./dictionary-sorter.mjs", | ||
| "dev:img": "node ./src/themes/octopus/utilities/img.mjs", | ||
| "dev:astro": "astro dev --mode staging", |
There was a problem hiding this comment.
Why astro dev --mode staging existed
It was there purely to serve the microsite footer, and my PR already removes it.
Astro loads .env.[mode] files, so --mode staging made pnpm dev pick up .env.staging — which held only the three shared-footer variables. Its own header comment spells out the purpose:
"Defaults match production. Edit temporarily to point at staging URLs (e.g. https://a.dev.octopus.com/...) when you want to preview upcoming shared navbar/footer changes locally before they ship to prod."
So: the footer HTML was fetched at build time from octopus.com/fragments/footer, and the flag let you repoint that fetch at a staging origin to preview footer changes before they went live. It was added in 247ce823e ("Integrate shared footer") — same commit that introduced the fetch.
With the fetch gone, both .env files are deleted and the mode has nothing left to load, so dev:astro is back to plain astro dev.
| footer has changed meaningfully and you want the safety net to stay roughly | ||
| current, or when `data-shared-source="fallback"` shows up on a deployed page. | ||
| Styles live in `src/styles/main.css` under `/* Footer */`. The footer repeats | ||
| the page's column template (`--page-grid-columns`) so its content lines up with |
There was a problem hiding this comment.
My right-nav PR changed the way the central column and right-nav are positioned. I've merged it, so recommend you rebase and check that this positioning rule/comment is still accurate
There was a problem hiding this comment.
Thanks for the heads up, checked and looks good to me
borland
left a comment
borland
left a comment
There was a problem hiding this comment.
Mostly LGTM. I have no complaints about the technical implementation, just a couple of small comments
The footer came from https://octopus.com/fragments/footer at build time, with CSS and JS loaded from the main site at page-view time. Replace it with an Astro component built to the Figma design, and delete the fetch, the snapshot fallback, and the Marketo forms that only ever rendered inside the imported markup. The nav column now spans the footer row of the content grid, so its divider runs to the bottom of the page as the design shows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The community Slack is being retired, so the link would break. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
887d048 to
8d92795
Compare
3 participants
Replaces the footer fetched from
octopus.com/fragments/footerwith an Astro component built to the Figma design.This is a big change to the status quo internal discussion here,
Results:
src/data/footer.ts, wording insrc/data/language.json..env.*, the three microsite stylesheets, and the Marketo forms that only rendered inside the imported markup.dateModifiedas microdata.TODO
Confirmed, remove shared footer, accept there will be a little future work to keep links up to date.
🤖 Generated with Claude Code