Document the date add filters - #3329
Closed
NickJosevski wants to merge 1 commit into
Closed
Conversation
Covers AddSeconds, AddMinutes, AddHours, AddDays, AddWeeks, AddMonths and
AddTimeSpan.
AddMonths gets its own section because it shifts by calendar month and
clamps the day to the end of a shorter month. AddTimeSpan gets one because
its {days}.{hours}:{minutes}:{seconds} format reads the leading field as
days above 23, so 48:00:00 is 48 days rather than 48 hours.
Also fixes pre-existing markdownlint violations in this file, which CI
surfaces because it lints only changed files. Table content is unchanged,
only cell padding and separator widths.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 10, 2026
|
Pull request environment is available at https://stoctodocspr3329.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
Contributor
Author
|
Closing — going with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the full filter set from OctopusDeploy/Octostache#126. Third variant, alongside #3326 (
AddHours/AddDays) and #3328 (AddTimeSpan).Structure
AddSeconds,AddMinutes,AddHours,AddDays,AddWeeks, with a worked example per unit including negatives, fractionals (AddHours "1.5",AddDays "2.5"= 60 hours) and theFormatchain.2030-01-31+ 1 month =2030-02-28, leap year, and backwards), with an info callout linking toDateTime.AddMonths.{days}.{hours}:{minutes}:{seconds}in a code block and linked to the .NETTimeSpan.Parseremarks.The warning callout
AddTimeSpan 48:00:00is 48 days, not 48 hours — with the table showing the23:00:00→24:00:00flip and the fact that24:01:02reads02as minutes rather than seconds. It closes by pointing atAddHours 48as the unambiguous alternative, which this variant has and #3328 didn't.A second callout covers quoting: the day form contains a
., which isn't valid in an unquoted filter argument.Verification
Every value in every table was produced by running the expression through the implementation, not written by hand.
Second commit
Fixes pre-existing markdownlint violations in
variable-filters.md— misaligned table pipes, asterisk lists, hard tabs. These already fail onmain; CI lints only changed files, so touching the page surfaces them. Padding only, no content change.Do not merge before OctopusDeploy/Octostache#126 ships.
🤖 Generated with Claude Code