NIT-3941: Remove one-time containers - #154
Merged
Merged
Conversation
pmikolajczyk41
requested review from
Tristan-Wilson,
eljobe and
ganeshvanahalli
October 2, 2025 11:28
…docker-containers # Conflicts: # test-node.bash
ganeshvanahalli
approved these changes
Oct 2, 2025
ganeshvanahalli
left a comment
ganeshvanahalli
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
I think its good to have this merged in before the next release<->master sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
./test-node.bashcreates a ton of auxiliary containers (used for one-shot actions, like config preparation). Unfortunately, the script doesn't remove then which:Generalizes #147
Closes NIT-3941
before:
after:
