Repository navigation
chore: [SDK-5527] add sticky log view to demo app - #2005
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sherwinski
reviewed
Oct 14, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
abdulraqeeb33
approved these changes
Oct 14, 2026
abdulraqeeb33
left a comment
Contributor
There was a problem hiding this comment.
LGTM, matches the shared Log View spec. A few nits inline, none blocking.
sherwinski
approved these changes
Oct 14, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add a sticky Log View to the React Native demo app so the shared Appium suite can assert on SDK listener events.
Details
Motivation
The shared demo spec (
sdk-shared/demo/build.mdPrompt 1.5, 2.0, 6.2 andstyles.mdLog View) requires an on-screen log of SDK events. Without it, the Appium suite skips the JS event assertions in specs 02 and 13 for React Native. This mirrors the Capacitor demo (LogService.ts,LogView.tsx).Scope
Demo app only (
examples/demo). No SDK source changes.LogService.ts: in-memory store (max 100 entries, never persisted) with a singlelog()helper that appends an entry and writes[OneSignal] {message}to the console.LogView.tsx: dark logcat-style panel pinned under the app bar, outside the main scroll view. ShowsLOGS ({count}), a clear button, and a collapse toggle; auto-scrolls to the newest entry. Collapsing sets the body height to 0, so entries stay in the view hierarchy.testIDs:log_view,log_entry_{index},log_clear_button,log_toggle_button.useOneSignal.ts: IAM, notification click/foregroundWillDisplay, push subscription, permission, and user change listeners all log throughlog()using the spec's exact message formats. Notification messages now includenotificationId.Podfile.lock: pod checksum refresh frompod install.Testing
Unit testing
None; demo UI only.
Manual testing
Ran the shared Appium suite locally with
run-local.sh --sdk=react-native:13_notification_click"opens the launch URL after a cold-start tap" (Launch URL never opened). It also fails onmainwithout this change, so it is a separate Android cold-start launch URL issue. Local runs bail on first failure, so the Android background-tap test in spec 13 did not run.Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code