Skip to content

Sungrow String and ESS Implementation - #2528

Open
Sn0w3y wants to merge 25 commits into
OpenEMS:developfrom
Sn0w3y:Sungrow-ESS-and-Sungrow-PV-Inverter
Open

Sungrow String and ESS Implementation#2528
Sn0w3y wants to merge 25 commits into
OpenEMS:developfrom
Sn0w3y:Sungrow-ESS-and-Sungrow-PV-Inverter

Conversation

@Sn0w3y

@Sn0w3y Sn0w3y commented Feb 7, 2024

Copy link
Copy Markdown
Collaborator

Based on the Implementation of @clehne in opernikus-common fork.
I adapted it to use ElectricityMeter

Thanks to them

@clehne
clehne requested a review from tsicking March 3, 2024 17:24
@sfeilmeier

Copy link
Copy Markdown
Contributor

We have too many open PRs with similar issues. I suggest we work on #2566 first (see the discussions on Coding Guidelines there). Afterwards we can re-open these PRs one at a time. Thanks!

@sfeilmeier
sfeilmeier marked this pull request as draft March 11, 2024 08:31
@github-actions

github-actions Bot commented Apr 1, 2024

Copy link
Copy Markdown

Code Coverage

@Sn0w3y
Sn0w3y marked this pull request as ready for review April 1, 2024 21:26
@Giermann

Copy link
Copy Markdown

Any news on this?
@tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

@Sn0w3y Sn0w3y closed this Aug 16, 2024
@Sn0w3y

Sn0w3y commented Aug 16, 2024

Copy link
Copy Markdown
Collaborator Author

Closed as i guess it is a WIP

@Sn0w3y
Sn0w3y deleted the Sungrow-ESS-and-Sungrow-PV-Inverter branch August 16, 2024 10:02
@Sn0w3y
Sn0w3y restored the Sungrow-ESS-and-Sungrow-PV-Inverter branch August 16, 2024 10:03
@codecov

codecov Bot commented Aug 16, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❗ There is a different number of reports uploaded between BASE (a7efc1c) and HEAD (d1e7cab). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (a7efc1c) HEAD (d1e7cab)
java 1 0
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #2528       +/-   ##
==============================================
- Coverage      55.70%   28.56%   -27.14%     
==============================================
  Files           3674      404     -3270     
  Lines         172011    12905   -159106     
  Branches       14175     2324    -11851     
==============================================
- Hits           95810     3685    -92125     
+ Misses         72409     9058    -63351     
+ Partials        3792      162     -3630     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tsicking

Copy link
Copy Markdown
Contributor

Any news on this? @tsicking would I be forced to merge the PR myself for my first experience with OpenEMS or is there any schedule planned to accept this PR?

We are still working on it and we are testing it thoroughly. I will update this PR when we are done. You can merge it yourself and can use it as a starting point.

@nishad-apollo

Copy link
Copy Markdown

@tsicking Any update on the sungrow inverter and ESS support for openEMS ? I can't find this anywhere.

@sfeilmeier

Copy link
Copy Markdown
Contributor

@nishad-apollo: Can you actually test the implementation with hardware? I could then re-open this PR for you and clean it up (e.g. moving everything to one common io.openems.edge.sungrow bundle)

@nishad-apollo

Copy link
Copy Markdown

@nishad-apollo: Can you actually test the implementation with hardware? I could then re-open this PR for you and clean it up (e.g. moving everything to one common io.openems.edge.sungrow bundle)

Sure, I want to test the bundle but not able to find in the develop branch, could you let me know then I could test it once. Is sungrow ESS and inverter still WIP or already released ?

@sfeilmeier

Copy link
Copy Markdown
Contributor

It's not officially released yet.
The latest "close to official" branch is here: https://github.com/Sn0w3y/openems/tree/Sungrow-ESS-and-Sungrow-PV-Inverter
If you are able to test it, we should be able to make it official relatively quickly. When are you planning to test it?

@nishad-apollo

nishad-apollo commented Aug 26, 2026

Copy link
Copy Markdown

Got it..

I got redirected to https://github.com/opernikus-common/openems from the comment section. Is this correct too ? Looks like forked from this repo. Or should i consider this specifically ? https://github.com/Sn0w3y/openems/tree/Sungrow-ESS-and-Sungrow-PV-Inverter

Test - Yes, Will start testing Next month, trying to figure the build now. Will update here, It will be great to make this official.

@sfeilmeier sfeilmeier reopened this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants