Implementation of Dutch Smart Meter over modbus TCP/IP - #3906
Open
Byonnem wants to merge 1 commit into
Open
Conversation
In the Netherlands, all smart meters are equiped with a 'P1' port. There are several generic TCP/IP converters available to implement smart home systems and this is widely adopted with tools like homeassistant and Homey. The aim of this pull is to improve accessability to OpenEMS for the dutch (and belgium and danish) market. The included component docs provide more context on how this should be setup. This meter component is not hardware vendor specific, as long as the modbus address table as listed in the doc is obeyed to. Any feedback on code quality is more then welcome, I'm just an amateur with some vibecoding skills. I should stick to hardware & high voltage ;) kind regards, Menno Spitteler
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #3906 +/- ##
==============================================
- Coverage 55.42% 28.31% -27.11%
==============================================
Files 3624 404 -3220
Lines 169393 12896 -156497
Branches 13987 2326 -11661
==============================================
- Hits 93875 3650 -90225
+ Misses 71799 9085 -62714
+ Partials 3719 161 -3558 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Netherlands, all smart meters are equiped with a 'P1' port. There are several generic TCP/IP converters available to implement smart home systems and this is widely adopted with tools like homeassistant and Homey. The aim of this pull is to improve accessability to OpenEMS for the dutch (and Belgium and Danish) market. The included component docs provide more context on how this should be setup. This meter component is not hardware vendor specific, as long as the modbus address table as listed in the doc is obeyed to.
Any feedback on code quality is more then welcome, I'm just an amateur with some vibecoding skills. I should stick to hardware & high voltage ;)
kind regards,
Menno Spitteler