Repository navigation
Avoid interactive test certificate prompts on Windows CI - #28
Merged
Merged
Conversation
raphaelscholle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-signing verification could hang when adding the self-signed certificate to the Windows current-user Root store, which can display an interactive security prompt. Import it into the disposable GitHub-hosted runner's machine trust stores instead, with progress logging.
The existing guards still reject execution outside ephemeral GitHub-hosted Actions runners, private keys, non-self-signed certificates, expired certificates and certificates without code-signing usage. Production jobs never import this certificate.
Validation: PowerShell parsing and workflow lint passed. The identical OpenHD trust helper passed end to end: verified GitHub origin, completed SignPath signing, valid timestamped Windows signature, and published Test-Signed package: https://github.com/OpenHD/OpenHD/actions/runs/41676851547.