Repository navigation
Conversation
xjjiang
changed the title
xjjiang
marked this pull request as ready for review
November 4, 2026 17:35
xjjiang
force-pushed
the
Nacelle_Wetted_Area
branch
from
November 4, 2026 18:29
dc55dd5 to
1f819e6
Compare
…to Nacelle_Wetted_Area
Kenneth-T-Moore
approved these changes
Nov 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It is confirmed that
Aircraft.Nacelle.SURFACE_AREAin GASP based geometry is the same asAircraft.Nacelle.WETTED_AREAin FLOPS based geometry. This PR replacesAircraft.Nacelle.SURFACE_AREAin GASP based geometry byAircraft.Nacelle.WETTED_AREAin FLOPS based geometry.It is relatively a simple modification of the code, but one unit test failed:
PreMissionTestCase.test_GASP_mass_FLOPS_everything_else()It requires an update in
CombinedGeometry.configure(). I have to move the promotes call down 1 level to catchAircraft.Nacelle.WETTED_AREAbefore it implicitly connected to the total wetted area component.See connect graph using a connection graph viewer in the OpenMDAO command line.
Computation of
Aircraft.Nacelle.TOTAL_WETTED_AREAis not included in GASP based geometry due to an old issue (issue #1176).Related Issues
Backwards incompatibilities
Aircraft.Nacelle.SURFACE_AREAis replaced by an existing variableAircraft.Nacelle.WETTED_AREA.AI Usage
None