Repository navigation
Fix to Multimission so that it supports adding external subsystems. - #1362
Open
Kenneth-T-Moore wants to merge 5 commits into
Open
Kenneth-T-Moore wants to merge 5 commits into
Kenneth-T-Moore wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some time ago, we changed the API for adding external subsystems so that they are added via
load_external_subsystems. This required delayingcheck_and_preprocess_inputsuntil after the subsystems are loaded. We never propagated that change into the multimission feature, and as a result,check_and_preprocess_inputswas called automatically duringadd_aviary_input, which is before the external subsystems are loaded. This resulted in some cryptic openmdao connection errors, particularly when one of the subsystems is propulsion.Related Issues
Backwards incompatibilities
The
check_and_preprocess_inputsmust now be manually called after all aviary groups are added to a multimission problem.AI Usage
Disclose any AI usage in this PR, including models used and files affected.