Repository navigation
Conversation
Author
|
Hello OpenShot maintainers, I would appreciate a review of PR #1111, which introduces The implementation has been committed and tested locally, I have also completed a follow-up QtPaintReader implementation The follow-up is currently available as a stacked PR in my fork: I intend to submit QtPaintReader upstream separately after Please let me know if any changes, additional tests, or Thank you for your time and consideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for constructing
QtImageReaderdirectly from anin-memory
QImage, without requiring an intermediate image file.Fixes #560
Motivation
Qt and QML applications can generate images dynamically, including
text, graphics, and overlays.
Previously, these images needed to be saved to disk before they
could be loaded by
QtImageReader.This enhancement allows applications to supply a
QImagedirectly.Implementation
QtImageReader(const QImage&)constructor.Tests
All 13 QtImageReader tests pass:
New tests cover:
Test command:
Result:
Serialization
Memory-backed images are transient.
Existing JSON serialization remains path-based and does not
serialize in-memory pixel data.
Applications requiring persistent project serialization should
use file-backed readers.
This limitation is documented in the public constructor API.
Compatibility
Existing file-backed QtImageReader behavior is preserved.
No changes to the public file-backed constructor are required.