Skip to content

Keep caption text readable with thick outlines - #1128

Merged
jonoomph merged 3 commits into
developfrom
caption-qt-fixes
Oct 18, 2026
Merged

jonoomph merged 3 commits into
developfrom
caption-qt-fixes

Conversation

@jonoomph

Copy link
Copy Markdown
Member

This fixes caption outlines covering the inside of letters, keeping text readable when a thick stroke is used.

  • Rendering: Draw the outline before the text fill, while preserving captions without outlines.
  • Regression coverage: Add a pixel-based check that reproduces the original defect.

Integrates #1107. Validated with caption/rendering tests and a short video export.

rajeshgk and others added 2 commits October 14, 2026 17:15
Draw caption outlines before filling glyphs so the stroke does not obscure the text interior.

Add a pixel-based regression test that fails with the original rendering order.

Fixes #1033
@jonoomph

Copy link
Copy Markdown
Member Author

@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.90110% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.84%. Comparing base (983c847) to head (efb91fd).

Files with missing lines Patch % Lines
tests/Caption.cpp 97.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1128      +/-   ##
===========================================
+ Coverage    73.75%   73.84%   +0.08%     
===========================================
  Files          273      273              
  Lines        36794    36884      +90     
===========================================
+ Hits         27139    27236      +97     
+ Misses        9655     9648       -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@jonoomph
jonoomph merged commit 7976991 into develop Oct 18, 2026
13 checks passed
@jonoomph
jonoomph deleted the caption-qt-fixes branch October 18, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants