Merge pull request #2717 from nxglabs/sync-to-public_repo-31818759561 - #2240
Merged
Conversation
Merge pull request #2716 from nxglabs/raktima-main-patch-security
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions and override constraints in the OpenSign server and web app packages, likely as part of a security/patch sync to the public repo.
Changes:
- Bumps several runtime dependencies in
apps/OpenSignServer(e.g., multer, nodemailer, parse/parse-server, sharp, ws). - Adds/adjusts npm
overridesentries to enforce minimum versions for selected transitive dependencies. - Updates
apps/OpenSigndev dependencypostcssand adds additionaloverrides(including nanoid/ws/protobufjs), with corresponding lockfile changes.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| apps/OpenSignServer/package.json | Updates server dependencies and expands overrides entries. |
| apps/OpenSignServer/package-lock.json | Lockfile updates for server dependency bumps and resolution changes. |
| apps/OpenSign/package.json | Updates postcss and adds additional overrides entries. |
| apps/OpenSign/package-lock.json | Lockfile updates reflecting new package resolutions (postcss/nanoid/ws). |
Files not reviewed (2)
- apps/OpenSign/package-lock.json: Generated file
- apps/OpenSignServer/package-lock.json: Generated file
Suppressed comments (1)
apps/OpenSignServer/package.json:91
- The declared Node.js engine range still includes Node 18, but updated dependencies now require newer Node versions (e.g., parse requires Node >=20.19.0 and sharp requires Node >=20.9.0 per package-lock). This can make installs fail or be non-functional on Node 18; please align the engines field with the new minimum supported Node version(s).
"engines": {
"node": "18 || 20 || 22"
}
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+85
to
+87
| "undici": "^7.29.0", | ||
| "uuid": ">=11.1.1", | ||
| "body-parser": ">=2.3.0" |
Comment on lines
104
to
108
| "eslint-plugin-react": "^7.37.5", | ||
| "jsdom": "^29.0.2", | ||
| "lint-staged": "^16.4.0", | ||
| "postcss": "^8.5.12", | ||
| "postcss": "^8.5.18", | ||
| "pretty-quick": "^4.2.2", |
| "undici": "^7.29.0", | ||
| "fast-uri": "^3.1.5" | ||
| "fast-uri": "^3.1.5", | ||
| "nanoid": ">=3.3.16", |
Comment on lines
45
to
49
| "qrcode": "^1.5.4", | ||
| "rate-limiter-flexible": "^9.1.1", | ||
| "sharp": "^0.34.5", | ||
| "sharp": "^0.35.3", | ||
| "speakeasy": "^2.0.0", | ||
| "ws": ">=8.21.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #2716 from nxglabs/raktima-main-patch-security