add nodeselector/affinity/tolerations/capabilities to separate r10k deployment - #10
add nodeselector/affinity/tolerations/capabilities to separate r10k deployment#10ke5C2Fin wants to merge 1 commit into
Conversation
|
this looks ok, please can you update the unit tests as needed, update the change long and bump the version number if you aren't already in the credits list at the bottom of readme then please do add yourself as a contributor thanks |
|
Can you tell me how I can test these tests? |
anthonysomerset
left a comment
There was a problem hiding this comment.
i've effectively reverted your changelog edit as has been superseded by auto changelog generation but otherwise all good so lgtm
I am not sure what to do about this failed CI check |
|
the CI issue is actually unrelated - the fix for that is in #22 |
|
OK so FYI i can't merge this until commits have verified signatures (semi-recent policy change) fastest solution i have found is
|
c8bb181 to
86cf95a
Compare
|
@anthonysomerset Didnt see that message until just now. |
|
its still failing the DCO check so its not detecting the commit as signed - see the guidance in the DCO action for more info I've also merged back in the changelog from MAIN as its now auto generated |
|
Success! Except the CHANGELOG.md again and it added a bunch of other things? |
…eployment Signed-off-by: Kevin Harrington <3482852+ke5C2Fin@users.noreply.github.com>
|
I have the signed piece working, not sure what is causing this CI failure. |
|
@anthonysomerset is this something I need to fix or is it a problem outside of this PR? |
add nodeselector/affinity/tolerations/capabilities to separate r10k deployment
fix | (pipe) spacing
move puppetserver.masters.affinity to template like puppetserver.compilers.affinity