Skip to content

add nodeselector/affinity/tolerations/capabilities to separate r10k deployment - #10

Open
ke5C2Fin wants to merge 1 commit into
OpenVoxProject:mainfrom
ke5C2Fin:affinity
Open

add nodeselector/affinity/tolerations/capabilities to separate r10k deployment#10
ke5C2Fin wants to merge 1 commit into
OpenVoxProject:mainfrom
ke5C2Fin:affinity

Conversation

@ke5C2Fin

@ke5C2Fin ke5C2Fin commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

add nodeselector/affinity/tolerations/capabilities to separate r10k deployment
fix | (pipe) spacing
move puppetserver.masters.affinity to template like puppetserver.compilers.affinity

@anthonysomerset

Copy link
Copy Markdown
Collaborator

this looks ok, please can you update the unit tests as needed, update the change long and bump the version number

if you aren't already in the credits list at the bottom of readme then please do add yourself as a contributor

thanks

@ke5C2Fin

Copy link
Copy Markdown
Contributor Author

Can you tell me how I can test these tests?
The unit tests appear to be very incomplete but I will try to get them better for what I am affecting.
Maybe you can link me something that explains it?

@anthonysomerset anthonysomerset left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've effectively reverted your changelog edit as has been superseded by auto changelog generation but otherwise all good so lgtm

@ke5C2Fin

ke5C2Fin commented May 6, 2026

Copy link
Copy Markdown
Contributor Author
Run helm repo add bitnami https://charts.bitnami.com/bitnami
"bitnami" has been added to your repositories
Error: plugin is installed but unusable: failed to load plugin at "/home/runner/.local/share/helm/plugins/helm-unittest.git/plugin.yaml": error unmarshaling JSON: while decoding JSON: json: unknown field "platformHooks"
Error: Process completed with exit code 1.

I am not sure what to do about this failed CI check

@anthonysomerset

Copy link
Copy Markdown
Collaborator

the CI issue is actually unrelated - the fix for that is in #22

@anthonysomerset

Copy link
Copy Markdown
Collaborator

OK so FYI

i can't merge this until commits have verified signatures (semi-recent policy change)

fastest solution i have found is

  1. ensure your git commit signing is setup and operational
  2. rebase the branch and squash it down to a single commit
  3. force push back to branch

@ke5C2Fin
ke5C2Fin requested a review from a team as a code owner June 18, 2026 15:41
@ke5C2Fin
ke5C2Fin force-pushed the affinity branch 2 times, most recently from c8bb181 to 86cf95a Compare June 18, 2026 15:51
@ke5C2Fin

Copy link
Copy Markdown
Contributor Author

@anthonysomerset Didnt see that message until just now.
I think I squashed/signed as needed please let me know.

@anthonysomerset

Copy link
Copy Markdown
Collaborator

its still failing the DCO check so its not detecting the commit as signed - see the guidance in the DCO action for more info

I've also merged back in the changelog from MAIN as its now auto generated

@ke5C2Fin

ke5C2Fin commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Success! Except the CHANGELOG.md again and it added a bunch of other things?
I followed the instructions in the DCO check...

…eployment

Signed-off-by: Kevin Harrington <3482852+ke5C2Fin@users.noreply.github.com>
@ke5C2Fin ke5C2Fin reopened this Jun 19, 2026
@ke5C2Fin

Copy link
Copy Markdown
Contributor Author

I have the signed piece working, not sure what is causing this CI failure.

/container-entrypoint.d/20-use-templates-initially.sh: line 10: cd: /opt/puppetlabs/server/data/puppetserver/.puppetlabs/etc/puppet: No such file or directory

@ke5C2Fin

Copy link
Copy Markdown
Contributor Author

@anthonysomerset is this something I need to fix or is it a problem outside of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants