Repository navigation
refactor: make every inventory connector a standalone file - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inventory connectors should run anywhere a single script can: unified-api, Ascender or another Ansible controller, a cron job. Until now each imported the SDK from the repository root, so a copied script failed on its own.
begin shared helpers/end shared helpersmarkers, and imports nothing from the repository.unified_connectors/inventory.pyis the reference copy;.github/scripts/check-helpers.sh(now in CI) fails when a copy differs, or when an inventory connector imports the SDK.run), still imported bykv.Checked: 82 tests pass; each connector copied alone into an empty folder starts and reports what it is missing; a cisco_ucs copy alone lists blades from a local fake manager; editing one copy makes the check fail.