Repository navigation
ci: publish the image before the tag and the release - #277
Merged
Merged
Conversation
Merging the release PR created the tag and the GitHub Release first and built the image after, so for the minutes of the build the new version was the latest release with no image to pull, and a failed build would have left a release whose image never existed. release-please now creates the release as a draft, which has no tag and nobody sees; the publish job builds the image from the release commit, pushes it, and only then publishes the draft, which creates the tag and makes it the latest release. A failed build leaves a draft; re-running the job finishes the release. The release docs say so and explain the one approval a release PR needs while github-actions[bot] is still a first-time contributor here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging the release PR created the tag and the GitHub Release first and built the image after: for the minutes of the build the new version was the latest release with no image to pull, and a failed build would have left a release whose image never existed. (Seen on unified-gitops 0.5.0, which has the same workflow; fixed there in OpusProjects/unified-gitops#45.)
release-please-config.json:"draft": true. release-please creates the release as a draft, which has no tag and nobody sees.release.yml: the publish job checks out the release commit, builds and pushes the image, and then publishes the draft (gh release edit --draft=false --latest), which creates the tag. A failed build leaves a hidden draft; re-running the job finishes the release.docs/releasing.mdandCLAUDE.mddescribe the new order and the one approval a release PR needs whilegithub-actions[bot]is still a first-time contributor here (open release PR chore: release v0.37.1 #273 will need it).