Repository navigation
Fix SSH console line endings on Unix - #302
Open
ST3FAN-dev wants to merge 1 commit into
Open
ST3FAN-dev wants to merge 1 commit into
ST3FAN-dev wants to merge 1 commit into
Conversation
|
Hi @Osiris-Team, I prepared 12 JUnit 5 regression tests for #302, preserving ST3FAN-dev's fix and credit. In an isolated harness, the actual production class fails 10 cases before the fix and passes all 12 afterward. This used dependency/test-runner stubs; full project CI and live SSH checks remain pending. Would you fund this separate test-only contribution for EUR 5 gross via PayPal, payable on acceptance and merge? #301 has no bounty assigned, so I am checking before submitting a claim. The work is Codex-assisted; I would complete project checks and account-owner review before a PR. Can payout details be shared privately? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301
What changed
Normalize bare LF (
\n) line endings to CRLF (\r\n) before writing console output to the built-in SSH terminal.Existing CRLF sequences are preserved.
Why
On Unix/Linux hosts, forwarded Minecraft/Paper console output uses LF-only line endings. The SSH terminal receives those bare LF characters unchanged, which causes the cursor to move down without returning to column 0 ("stair-step" output).
On Windows, the issue was not visible because the forwarded output already used CRLF.
Tested
Also tested through the built-in AutoPlug SSH console.