Shape\Drawing\File : Name an image file whose path does not name itself

[dkulyk]

Closes #603.

Description

What is wrong

Shape\Drawing\File::getExtension() derives the extension from the path alone:

return pathinfo($this->getPath(), PATHINFO_EXTENSION);

A path is free to carry no extension — an upload stored under its hash, a file from tempnam(), an image served from a route — and then the answer is ''. getIndexedFilename() builds the name of the media part out of it, so the part is called logo1., ending in a bare dot. Both writers register content types by extension, so that part is written under none.

The change

The contents say what the name does not, and the same call already backs getMimeType() a few lines below:

$image = getimagesizefromstring(CommonFile::fileGetContents($this->getPath()));

return is_array($image) ? (string) image_type_to_extension($image[2], false) : '';

It runs only when pathinfo() came back empty and the file exists, so a path that has an extension costs exactly what it cost before — no file is opened.

What it does not do

An extensionless SVG stays extensionless. getimagesizefromstring() reports nothing for it, and there is nothing else in the file for the decision to rest on. Neighbouring reports #741 and #819 are about the same family of images-loaded-from-content problems and are not touched here.

Checklist:

• My CI is 🟢
• I have covered by unit tests my new code (check build/coverage for coverage report)

  FileTest::testPathWithoutAnExtension — the repository's own PNG copied to a tempnam() path, so no binary fixture is added. Checked by putting the one-line getExtension() back: the test fails.

• I have updated the documentation to describe the changes

  No documented API changed.

• I have updated the changelog

[coveralls]

coverage: 92.161% (+0.002%) from 92.159% — sapientpro:fix/extensionless-image into PHPOffice:master