AMM-1575 Added ABHA language variables - #186
Conversation
WalkthroughSix new localization keys related to ABHA (Ayushman Bharat Health Account) were added to the Assamese, English, and Hindi language JSON resource files. These additions provide translations for ABHA terms and messages, expanding the available UI labels without modifying or removing any existing entries. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/assets/English.json (1)
1718-1722: Verify new ABHA keys are added in all language files & consumed in UIThe six keys look fine, but:
- Confirm identical keys exist in
Assamese.json,Hindi.json, and any other locales to avoid i18n fall-throughs.- Make sure the frontend actually references these keys; otherwise they remain dead strings.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
src/assets/Assamese.json(1 hunks)src/assets/English.json(1 hunks)src/assets/Hindi.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: lint-and-audit / lint-and-audit
- GitHub Check: Build
🔇 Additional comments (1)
src/assets/English.json (1)
1716-1717: Rename typo in translation keybeneficaryConsent→beneficiaryConsent
- File:
src/assets/English.json, line 1716- Diff:
-"beneficaryConsent":"Beneficiary Consent", +"beneficiaryConsent":"Beneficiary Consent",- I ran
rgand confirmed this is the only occurrence in the repo—no references to the old or new key were found.- Please update any code look-ups (e.g.
t('beneficaryConsent')) to usebeneficiaryConsentand verify that translations render correctly at runtime.
| "benPreviousVisitDetails": "Beneficiary previous visit details", | ||
| "startDataSync": "Start Data Sync" | ||
| "startDataSync": "Start Data Sync", | ||
| "abha":"ABHA", | ||
| "abhaNumber":"ABHA Number", | ||
| "abhaDetails":"ABHA Details", | ||
| "abhaAddress":"ABHA Address", | ||
| "abhaMode":"ABHA Mode", | ||
| "abhaDetailsNotAvailable":"ABHA details not available" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
JSON invalid – missing comma before newly-added keys and untranslated Hindi strings
benPreviousVisitDetails(l. 1704) now is not the last property but lacks a trailing comma → the whole file is invalid JSON and will not parse.- Newly-added keys keep English text inside the Hindi bundle – breaks UX consistency.
- Prefer “आभा” for the acronym (in Devanagari) and proper Hindi translations for the rest.
Apply:
- "benPreviousVisitDetails": "Beneficiary previous visit details"
+ "benPreviousVisitDetails": "Beneficiary previous visit details",
+ "startDataSync": "डेटा सिंक प्रारंभ करें",
+ "abha": "आभा",
+ "abhaNumber": "आभा संख्या",
+ "abhaDetails": "आभा विवरण",
+ "abhaAddress": "आभा पता",
+ "abhaMode": "आभा मोड",
+ "abhaDetailsNotAvailable": "आभा विवरण उपलब्ध नहीं है"Committable suggestion skipped: line range outside the PR's diff.
🤖 Prompt for AI Agents
In src/assets/Hindi.json around lines 1704 to 1711, add a trailing comma after
the "benPreviousVisitDetails" entry to fix the JSON syntax error. Replace the
English text values of the new keys with their proper Hindi translations, using
"आभा" for the acronym "abha" to maintain UX consistency and correct
localization.
| "startDataSync": "Start Data Sync", | ||
| "abha":"ABHA", | ||
| "abhaNumber":"ABHA Number", | ||
| "abhaDetails":"ABHA Details", | ||
| "abhaAddress":"ABHA Address", | ||
| "abhaMode":"ABHA Mode", | ||
| "abhaDetailsNotAvailable":"ABHA details not available" |
There was a problem hiding this comment.
Untranslated English strings break localisation consistency
Every other entry in this Assamese bundle is translated, but the newly-added keys keep the English source text. This will show up in the UI as a jarring language switch.
- "startDataSync": "Start Data Sync",
- "abha":"ABHA",
- "abhaNumber":"ABHA Number",
- "abhaDetails":"ABHA Details",
- "abhaAddress":"ABHA Address",
- "abhaMode":"ABHA Mode",
- "abhaDetailsNotAvailable":"ABHA details not available"
+ "startDataSync": "ডাটা চিঙ্ক আৰম্ভ কৰক",
+ "abha":"এবিএইচএ (ABHA)",
+ "abhaNumber":"এবিএইচএ নম্বৰ",
+ "abhaDetails":"এবিএইচএৰ সবিশেষ",
+ "abhaAddress":"এবিএইচএ ঠিকনা",
+ "abhaMode":"এবিএইচএ মোড",
+ "abhaDetailsNotAvailable":"এবিএইচএৰ সবিশেষ উপলব্ধ নহয়"Please supply accurate Assamese equivalents (the above are indicative) or get them vetted by your localisation team before merging.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "startDataSync": "Start Data Sync", | |
| "abha":"ABHA", | |
| "abhaNumber":"ABHA Number", | |
| "abhaDetails":"ABHA Details", | |
| "abhaAddress":"ABHA Address", | |
| "abhaMode":"ABHA Mode", | |
| "abhaDetailsNotAvailable":"ABHA details not available" | |
| "startDataSync": "ডাটা চিঙ্ক আৰম্ভ কৰক", | |
| "abha": "এবিএইচএ (ABHA)", | |
| "abhaNumber": "এবিএইচএ নম্বৰ", | |
| "abhaDetails": "এবিএইচএৰ সবিশেষ", | |
| "abhaAddress": "এবিএইচএ ঠিকনা", | |
| "abhaMode": "এবিএইচএ মোড", | |
| "abhaDetailsNotAvailable": "এবিএইচএৰ সবিশেষ উপলব্ধ নহয়" |
🤖 Prompt for AI Agents
In src/assets/Assamese.json around lines 1704 to 1710, the newly added keys
contain English text instead of Assamese translations, breaking localization
consistency. Replace the English strings with accurate Assamese translations for
each key or consult the localization team to provide verified Assamese
equivalents before merging.
2 participants
📋 Description
JIRA ID: AMM-1575
Added abha language variables
✅ Type of Change
ℹ️ Additional Information
Please describe how the changes were tested, and include any relevant screenshots, logs, or other information that provides additional context.
Summary by CodeRabbit