Add custom checks stores & storage checks by rbev · Pull Request #5668 · Particular/ServiceControl

rbev · 2026-07-30T07:57:37Z

This pull request adds support for storing custom check data in both PostgreSQL and SQL Server EF Core persistence layers. It introduces new migration files and updates the database model snapshots to include a new CustomChecks table. Additionally, there are minor updates to the .NET SDK version and some code organization improvements.

Database schema changes:

Added a new custom_checks table for PostgreSQL and a CustomChecks table for SQL Server, including columns for IDs, category, status, timestamps, failure reasons, and endpoint information. [1] [2]
Updated model snapshot files (PostgreSqlServiceControlDbContextModelSnapshot.cs, SqlServerServiceControlDbContextModelSnapshot.cs) to reflect the addition of the CustomCheckEntity and its mapping to the new tables. [1] [2]
Added EF Core migration designer file for SQL Server to support the new CustomChecks table.

Build and configuration updates:

Updated the .NET SDK version in global.json from 10.0.100 to 10.0.302 and changed the rollForward policy to disable.

Code and dependency improvements:

Added missing using CustomChecks; directives to relevant files for clarity and to ensure correct namespace usage. [1] [2]
Refactored the persistence configuration to clarify variable usage when creating the SqlServerPersistence instance.

johnsimons · 2026-07-30T09:39:26Z

@rbev just wondering if this is doing the same as #5658

johnsimons · 2026-07-30T09:51:38Z

@rbev I think there is a misunderstanding here.
The reason we have a custom check for disk space for RavenDB Embedded is because we are in total control of the raven instance, we are hosting it ourselves. We do not monitor disk space for external RavenDB servers!
So, in our case both PostgreSQL and SqlServer are external resources so there is no need for us to do that. We assume that the database administrator would do those things or on the cloud the size automatically scales or they have other mechanisms to monitor these.

rbev · 2026-07-31T06:01:59Z

+            Status = c.Status,
+            ReportedAt = c.ReportedAt,
+            FailureReason = c.FailureReason
+        }).ToList(), new QueryStatsInfo("", page.Count, false));


Etag left blank, it will be revisited as part of other work.

johnsimons · 2026-07-31T06:39:40Z

@@ -1,5 +1,6 @@
 namespace ServiceControl.Persistence.EFCore.SqlServer;

+using CustomChecks;


do we need this?

johnsimons · 2026-07-31T06:42:12Z

+        if (customCheck == null ||
+            (customCheck.Status == Status.Fail && !detail.HasFailed) ||
+            (customCheck.Status == Status.Pass && detail.HasFailed))


That is confusing!

It's a direct cut & paste from the raven implementation

johnsimons · 2026-07-31T06:43:22Z

+        customCheck.CustomCheckId = detail.CustomCheckId;
+        customCheck.Category = detail.Category;
+        customCheck.Status = detail.HasFailed ? Status.Fail : Status.Pass;
+        customCheck.ReportedAt = detail.ReportedAt;


Should this be updated everytime it changes or should it be the first time?

Raven updates everything every time, but actually it should use the upsert utility that exists now

johnsimons · 2026-07-31T06:45:17Z

+        var customCheck = await context.CustomChecks.FindAsync(id);
+        if (customCheck != null)
+        {
+            context.CustomChecks.Remove(customCheck);
+            await context.SaveChangesAsync();
+        }


You can do this in one query using the ExecuteDeleteAsync

johnsimons · 2026-07-31T06:47:17Z

+    "version": "10.0.302",
    "allowPrerelease": false,
-    "rollForward": "latestFeature"
+    "rollForward": "disable"


I don't think we should do this without talking to Brandon!

or at least do it in a different PR so we can bring him in for a review.

Yeah sorry, had just done it on this branch to test and forgot to revert it

internalautomation Bot assigned rbev Jul 30, 2026

rbev requested review from abparticular, johnsimons and warwickschroeder July 30, 2026 07:58

rbev marked this pull request as ready for review July 30, 2026 08:03

rbev added 6 commits July 31, 2026 13:41

Add custom checks shared implementation

8b18c8d

Add storage checks for sql server

9b351a4

Add postgres disk space checks

6193e00

use valid value for rollforward

3a8ebe8

Revert custom checks for database space

221c6b8

Add db migrations

f9804f5

rbev force-pushed the rhys/sql-customchecks2 branch from 4c78340 to f9804f5 Compare July 31, 2026 05:42

rbev added 2 commits July 31, 2026 13:44

fix formatting

e108d56

Remove unused usings

b32bae0

rbev commented Jul 31, 2026

View reviewed changes

johnsimons requested changes Jul 31, 2026

View reviewed changes

		@@ -1,5 +1,6 @@
		namespace ServiceControl.Persistence.EFCore.SqlServer;

		using CustomChecks;

Uh oh!

Conversation

rbev commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnsimons commented Jul 30, 2026

Uh oh!

johnsimons commented Jul 30, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rbev commented Jul 30, 2026 •

edited

Loading