Repository navigation
Audit documented work; fix cue timing, audio snapshot fidelity and validation gaps - #210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented audits still exposed several reproducible control and validation defects. A late timeline Play could consume AutoFollow before playback, loop-mode edits shifted oscillator phase, and snapshots omitted the Audio input/measure/frequency controls.
This fixes those paths, selects software decoding on macOS for ProRes 4444/XQ transparency preservation, and corrects the endurance analyzer and benchmark acceptance targets. Video regressions now accept the valid NV12 hardware layout and isolate the CPU memory-budget test from zero-copy frames. No image-fidelity or timing thresholds are relaxed.
docs/audit-status-2026-10-19.mdmaps all 15 documents to current implementation and remaining work; the docs index and stale claims are updated. Open work includes complete ISF freeze/resume, long-stall clock policy, color/output precision and physical receiver/endurance measurements.Validation: native macOS application, engine tests and benchmark compiled with Qt 6.12 / FFmpeg 9. All 18 locally runnable CTest areas pass, including five new regression areas (three Python analyzer tests). The three new engine regression executables also pass with AddressSanitizer + UndefinedBehaviorSanitizer (leak detection disabled; no leak-check claim). The new show-clock regression failed on six assertions before the fixes; audio snapshot capture/restore/recreation failed on three. Local offscreen Qt cannot create GL contexts, so GL areas and multiplatform/sanitizer validation remain CI requirements. ProRes hardware initialization is unavailable locally; the fallback policy is based on the documented hardware alpha-loss reproduction and the new decoder-only alpha ramp check.
Software ProRes 4444 decoding may cost additional CPU; measure the intended multilayer show before accepting performance.
Existing snapshots recorded without the Audio source controls cannot recover values that were never saved; recapture those routes after updating. Full Linux and Windows validation, workspace ASan, TSan, fuzzing and the UI scenario have passed on this head. macOS validation is still running.