Repository navigation
Normalize source color profiles and add per-viewport SDR output transforms - #214
Merged
Merged
Conversation
…lative fader timing
reno-
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixed source profiles previously entered compositing unchanged, and unknown/live sources could not be declared. Add Source color space with Auto and explicit SDR declarations. Normalize native sources to encoded sRGB before Color/FX/compositing, preserving straight alpha and 16-bit integer precision. Auto uses embedded image ICC profiles and supported video frame/container tags. Overrides use original samples, survive project saves/recalls and support Undo; groups and layer references are not decoded twice.
Display original source color metadata in the Media Bin and Source details. Add per-viewport SDR output space/exposure transforms shared by preview, screens and publishing. Fix output color settings being omitted from viewport attribute paste.
Review of PRs #212–#214 also found that a new manual fader/blackout could count elapsed time from before its command after a render stall. Give each a command-relative clock, with deterministic regression coverage. Preset/snapshot integrity and image-precision checks remain passing.
Validation: full engine, rendering, UI and timing suites pass on Linux, Windows and macOS. Linux ASan workspace lifetime, ThreadSanitizer and fuzzing pass. Seven focused local tests pass; three also pass ASan/UBSan (leak detection disabled). A software-rendered inspector probe verifies declaration, Undo refresh, locked controls and layout at narrow panel widths. Package extraction/startup smoke tests also pass on all three platforms.
Keep
docs/README.mdlimited to concise problems and remaining work. Current color limits include encoded sRGB rather than linear-light compositing, sRGB gamut clipping even for P3 output, unmanaged ISF image inputs, unsupported video profiles/HDR, display ICC/output signaling and physical 10-bit verification.