feat(place/bookings): add timeline settings for booking panel - #626
Conversation
Expose show_timeline and timeline_position bindings for the booking panel timeline view (PPT-2570). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Greptile SummaryThe PR exposes booking-panel timeline visibility and placement settings through Bookings driver status.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking configuration-hardening issue around unsupported timeline positions. The new boolean binding and defaults are straightforward, but timeline_position forwards empty or unsupported strings despite documenting a finite set of values. Files Needing Attention: drivers/place/bookings.cr
|
| Filename | Overview |
|---|---|
| drivers/place/bookings.cr | Adds the two timeline status bindings, but timeline_position does not enforce its documented finite-value contract. |
| drivers/place/bookings_spec.cr | Verifies both default statuses but does not cover configured or unsupported timeline positions. |
Reviews (1): Last reviewed commit: "feat(place/bookings): add timeline setti..." | Re-trigger Greptile
| self[:enable_end_meeting_button] = setting?(Bool, :enable_end_meeting_button) || false | ||
|
|
||
| self[:show_timeline] = setting?(Bool, :show_timeline) || false | ||
| self[:timeline_position] = setting?(String, :timeline_position) || "bottom" |
There was a problem hiding this comment.
Unvalidated timeline position setting
timeline_position publishes any configured string even though the setting documents a finite set of supported values. An empty value or configuration typo therefore reaches the booking panel instead of falling back to a supported position, leaving the consumer to handle an undocumented state.
Summary
show_timeline(bool, defaultfalse) andtimeline_position(string, defaultbottom; valid:left,right,bottom,floating-left,floating-bottom) as status bindings in the Bookings driver🤖 Generated with Claude Code