Skip to content

feat(place/bookings): add timeline settings for booking panel - #626

Merged
naqvis merged 1 commit into
masterfrom
feat/booking-timeline-settings
Aug 10, 2026
Merged

feat(place/bookings): add timeline settings for booking panel#626
naqvis merged 1 commit into
masterfrom
feat/booking-timeline-settings

Conversation

@MrYuion

@MrYuion MrYuion commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Expose show_timeline (bool, default false) and timeline_position (string, default bottom; valid: left, right, bottom, floating-left, floating-bottom) as status bindings in the Bookings driver
  • Required by the booking panel timeline view frontend changes (PPT-2570)
  • Spec asserts both defaults; harness passes

🤖 Generated with Claude Code

Expose show_timeline and timeline_position bindings for the booking
panel timeline view (PPT-2570).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@MrYuion
MrYuion requested a review from stakach August 10, 2026 05:42
@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown

Greptile Summary

The PR exposes booking-panel timeline visibility and placement settings through Bookings driver status.

  • Adds show_timeline with a false default.
  • Adds timeline_position with a bottom default and documents the supported positions.
  • Extends the driver spec to assert both defaults.

Confidence Score: 4/5

The PR appears safe to merge, with a non-blocking configuration-hardening issue around unsupported timeline positions.

The new boolean binding and defaults are straightforward, but timeline_position forwards empty or unsupported strings despite documenting a finite set of values.

Files Needing Attention: drivers/place/bookings.cr

Important Files Changed

Filename Overview
drivers/place/bookings.cr Adds the two timeline status bindings, but timeline_position does not enforce its documented finite-value contract.
drivers/place/bookings_spec.cr Verifies both default statuses but does not cover configured or unsupported timeline positions.

Reviews (1): Last reviewed commit: "feat(place/bookings): add timeline setti..." | Re-trigger Greptile

Comment thread drivers/place/bookings.cr
self[:enable_end_meeting_button] = setting?(Bool, :enable_end_meeting_button) || false

self[:show_timeline] = setting?(Bool, :show_timeline) || false
self[:timeline_position] = setting?(String, :timeline_position) || "bottom"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Unvalidated timeline position setting

timeline_position publishes any configured string even though the setting documents a finite set of supported values. An empty value or configuration typo therefore reaches the booking panel instead of falling back to a supported position, leaving the consumer to handle an undocumented state.

@MrYuion
MrYuion requested a review from chillfox August 10, 2026 05:46

@naqvis naqvis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naqvis
naqvis merged commit e0e7ba4 into master Aug 10, 2026
4 of 7 checks passed
@naqvis
naqvis deleted the feat/booking-timeline-settings branch August 10, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants