Repository navigation
fix: leave the content folders to the site's 404 when redirecting to a directory index - #522
Merged
Merged
Conversation
…a directory index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #521, found by comparing the HTTP answers of a Linux DDEV project (nginx-fpm and apache-fpm, 18 URLs) before and after it.
Under Apache,
/cms/wp-content/and/cms/wp-content/plugins/answered 404 (the skeleton's .htaccess sends the content folders to the front controller on purpose, so a visitor is not told they exist); #521's redirect to a directory'sindex.phpturned them into a 302 to.../index.php. The redirect now skips/content/and/cms/wp-content/.After this change the 18 URLs answer exactly as before #521 on both servers; Valet and Herd on macOS keep
/cms/wp-admin/working.