Rename default_version from 1.0.0 to stable - #40
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @jnasbyupgrade's task in 2m 6s —— View job Claude's Review
This is a clean, mechanical re-land of #26's content, and the change is internally consistent:
One pre-existing stale comment worth fixing while you're here (not introduced by this PR, but this PR is exactly what invalidates it):
# `sql/ test/`: sql/extension_drop--1.0.0.sql is a frozen, already-released
# version file (RELEASE.md's "Ongoing development" section -- once a version
# is released, its sql/<ext>--<version>.sql is never hand-edited again), soThis now references a file this PR deletes, and its premise ("already-released") was already inaccurate before this PR too — per this PR's own description, No functional issues found. |
|
Claude finished @jnasbyupgrade's task in 1m 8s —— View job Claude's Review
This is a clean, mechanical re-land of #26's content, and the change is internally consistent:
Pre-existing stale comment still present (not introduced by this PR, flagged in the prior review pass, still unaddressed):
# `sql/ test/`: sql/extension_drop--1.0.0.sql is a frozen, already-released
# version file (RELEASE.md's "Ongoing development" section -- once a version
# is released, its sql/<ext>--<version>.sql is never hand-edited again), so
# linting it would produce permanent, unfixable findings and make `make
# lint` unusable as a CI gate. Lint the hand-maintained source instead.This now references a file this PR deletes, and its premise ("already-released") was already inaccurate before this PR too — per this PR's own description, No functional issues found. |
Re-lands the content of #26, which was accidentally lost.
#26 ("Rename default_version from 1.0.0 to stable") legitimately merged into the
fix-cat-tools-installbranch, creating commit f08db32. That branch was later reset/rebased back to an earlier point before it itself was squash-merged intomaster(as part of #10), so f08db32's changes never actually reachedmasterdespite #26 showing as MERGED on GitHub. The commit object still exists in the repo but isn't an ancestor ofmasteror any other branch.This PR cherry-picks f08db32's content back onto current
master(resolving conflicts in HISTORY.asc caused by unrelated history added since then). Same intent as #26:extension_drop.control:default_version = 'stable'(was1.0.0, which was never actually tagged or published to PGXN — the only real release ever published was0.1.1in 2017).stableis an honest label for "current unreleased source", matching pg_count_nulls#13's convention, until a real release is cut.sql/extension_drop--1.0.0.sqlremoved — sincestableis a pseudo-version, its versioned sql file (sql/extension_drop--stable.sql) is now generated at build time rather than committed (see.gitignoreupdate).META.in.json/META.json: version fields updated tostable.HISTORY.asc: heading renamed from1.0.0toSTABLE.Verified with
make test(all test groups pass) andmake lint(zero findings) against currentmaster.See #26 for the original rationale/discussion.