CI: register inline-comment MCP tool for claude-code-review - #23
Open
jnasbyupgrade wants to merge 1 commit into
Open
CI: register inline-comment MCP tool for claude-code-review#23jnasbyupgrade wants to merge 1 commit into
jnasbyupgrade wants to merge 1 commit into
Conversation
The review step drives claude-code-action with a bare prompt: (no @claude mention), which runs it in "agent mode". That mode decides which MCP servers to start from an --allowedTools flag inside claude_args, not from the invoked plugin's own allowed-tools frontmatter. Without mcp__github_inline_comment__create_inline_comment listed there, that MCP server never starts, so the code-review plugin silently falls back to one consolidated PR comment instead of real per-line inline comments.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-code-review.yml's review step drivesclaude-code-actionwith a bareprompt:(no@claudemention), which runs the action in "agent mode." In that mode the action decides which MCP servers to start from an--allowedToolsflag insideclaude_args, not from the invoked plugin's ownallowed-toolsfrontmatter. Withoutmcp__github_inline_comment__create_inline_commentlisted there, that MCP server never started, so thecode-reviewplugin silently fell back to a single consolidated PR comment instead of real per-line inline comments — no error, no warning, just the wrong output shape. Fixed by addingclaude_args: '--allowedTools mcp__github_inline_comment__create_inline_comment'.Investigated, not changed
permissions: actions: writeto let the job's internal cache-save step (insideclaude-code-action's own setup) succeed instead of emitting aCache reservation failed: cache write denied: token has no writable scopeswarning. Checked a sibling repo's identical review workflow that already grantsactions: write: the warning still appears in its runs both immediately after that permission was added and in its most recent run — so the permission does not actually resolve the warning in practice. Not adding it here since it wouldn't fix anything and would only grant unused, broader privileges (cancelling/deleting workflow runs, managing artifacts).Test plan
.github/workflows/claude-code-review.ymlpull_request_targetalways runs the workflow frommaster, so this PR's own check reflects the OLD workflow, not this change — verification of the MCP fix happens on a subsequent PR after merge)🤖 Generated with Claude Code