Fix claude-code-review.yml trust gate: check PR author, not head repo owner - #26
Open
jnasbyupgrade wants to merge 1 commit into
Open
Conversation
… owner head.repo.owner.login only identifies who owns the fork on fork-headed PRs. For an upstream-branch-headed PR (base and head both in this repo -- e.g. from gh stack, or gh pr create without a fork), it's always this repo's own org, never the actual author, so the gate silently skipped review on every such PR regardless of who opened it. Check pull_request.user.login instead, which identifies the actual PR author in both cases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
claude-reviewjob's trust gate checked:github.event.pull_request.head.repo.owner.login == 'jnasbyupgrade'head.repo.owner.loginonly identifies "who owns the fork" for fork-headed PRs. For an upstream-branch-headed PR (base and head both in this repo -- required bygh stack, and also just what you get fromgh pr createwithout a fork),head.repo.owner.loginis always the repo's own org, never the actual PR author -- so the gate silently skipped review on every such PR regardless of who opened it.Fix: check the PR author instead:
github.event.pull_request.user.login == 'jnasbyupgrade'PR author can't be spoofed by a third party any more than head repo owner can, and it's the more direct question for this gate's actual purpose (trusting the PERSON asking for review, not the repository their branch happens to live in). Works for both fork-headed and upstream-branch-headed PRs.