Initial version of libpower-grid-model-java - #4
Closed
gerritdrost wants to merge 14 commits into
Closed
Conversation
Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
Signed-off-by: Mahmut Tumkaya <mahmut.tumkaya@alliander.com>
Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
Signed-off-by: Mahmut Tumkaya <mahmut.tumkaya@alliander.com>
Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
Signed-off-by: Wei-Qiang Zhou <wei-qiang.zhou@alliander.com>
Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
- uses DSA code style (through eclipse code style file) - adds licence header to all Java files Signed-off-by: Wei-Qiang Zhou <wei-qiang.zhou@alliander.com>
- Add license header to gradle files - Remove license header from gradle-wrapper.properties Signed-off-by: Wei-Qiang Zhou <wei-qiang.zhou@alliander.com>
- Add github workflow - Move fileTree call out of doLast - Add license header - Remove author and description in actions Signed-off-by: Wei-Qiang Zhou <wei-qiang.zhou@alliander.com>
Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
gerritdrost
marked this pull request as ready for review
August 4, 2026 13:32
gerritdrost
commented
Aug 4, 2026
| uses: actions/setup-java@03ad4de0992f5dab5e18fcb136590ce7c4a0ac95 # 5.6.0 | ||
| with: | ||
| java-version: ${{ inputs.java_version }} | ||
| distribution: 'zulu' |
Author
There was a problem hiding this comment.
Azul Zulu is the default JVM inside Alliander (Alliander has a contract). Should we use this here, or should we use Eclipse Temurin?
gerritdrost
commented
Aug 4, 2026
Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
…n message Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
Signed-off-by: Gerrit Drost <gerrit.drost@alliander.com>
Member
|
I am closing this PR. @gerritdrost now you are part of PGM organization. Please re-push the branch to this repo directly (not fork), then create an internal PR. |
Member
|
See #5 for active PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge instructions
This PR is a merger of work by @Mahmuttumkaya, @wei-qiang and me. A merge without squash has our preference as it retains authorship of the code, which has our preference.
From now on we aim to provide concise PR's which can then be squash merged.
Changes in this PR
Java project that implements a wrapper to the PGM C library. Currently implemented:
power_grid_model_c_example/main.c)Future improvements
A non-exhaustive list of things we should improve in the future:
build.gradle)