Repository navigation
fix(xlsx): Fixes the datatype for numerical cells - #217
Merged
Merged
Conversation
Made sure that the cells are numerical data if they are numbers
Contributor
Author
|
@oyessb Could you test this out and see if it solves the problem? |
oyessb
reviewed
Nov 3, 2026
|
|
||
| if (value.IsNumeric()) | ||
| { | ||
| setCell( |
Collaborator
There was a problem hiding this comment.
Should the same parsing be done here like for the Xlsx2Serializer?
double numericValue = double.Parse(value, CultureInfo.InvariantCulture);
Collaborator
|
@likp I have made tests for both XlsxSerializer and Xlsx2Serializer to check if the cell datatype is Number for numeric values. Is it okay if i push them to this branch together with the double.Parse(..) as mentioned in the comment above? |
Updated code to parse numeric values with double.Parse and CultureInfo.InvariantCulture before setting cell values, ensuring correct number formatting in Excel sheets.
Added Xlsx2SerializerTest to verify numeric cells are written as Excel numbers using reflection for indentation logic. Added similar test to XlsxSerializerTest. Both use BE0101A1.px and assert numeric cells are XLDataType.Number. Minor refactoring and whitespace changes in XlsxSerializerTest.cs.
|
likp
marked this pull request as ready for review
November 3, 2026 14:23
likp
requested review from
JohannesFinsveen,
MikaelNordberg and
runejo
as code owners
November 3, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All data cells are formatted as string in the Excel output. This PR changes this so that data cells are formatted as numerical if the data value is numerical.