Skip to content

fix: accept single-quoted SSO config assignments - #177

Closed
jck-longhair wants to merge 2 commits into
Pyhass:devfrom
jck-longhair:fix-sso-single-quotes
Closed

jck-longhair wants to merge 2 commits into
Pyhass:devfrom
jck-longhair:fix-sso-single-quotes

Conversation

@jck-longhair

Copy link
Copy Markdown

Fixes #176.

The SSO page switched from window.Key="value", to window.Key = 'value';.
_SSO_ASSIGNMENT now accepts either quote style. Adds a regression test for the new
format (fails on current dev, passes with this change).

pytest tests/ (1062 passed, 100% coverage) and pre-commit run pass locally.

@codecov

codecov Bot commented Oct 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (2979710) to head (3bb18e3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #177   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          30       30           
  Lines        2643     2643           
  Branches      310      310           
=======================================
  Hits         2642     2642           
  Partials        1        1           
Flag Coverage Δ
unittests 99.96% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/api/hive_api.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KJonline

Copy link
Copy Markdown
Contributor

Duplicate PR fixed here: #169

@KJonline KJonline closed this Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] get_login_info fails: SSO page now uses single-quoted assignments

2 participants