Skip to content

[MRG] Stabilize simplex projection against large common offsets - #880

Open
AHMETHAKANBEZIR1 wants to merge 9 commits into
PythonOT:masterfrom
AHMETHAKANBEZIR1:fix/simplex-translation-stability
Open

AHMETHAKANBEZIR1 wants to merge 9 commits into
PythonOT:masterfrom
AHMETHAKANBEZIR1:fix/simplex-translation-stability

Conversation

@AHMETHAKANBEZIR1

@AHMETHAKANBEZIR1 AHMETHAKANBEZIR1 commented Oct 2, 2026 •

Copy link
Copy Markdown

Summary

Fixes #879. Simplex projection is invariant to a common offset per column. Center floating inputs before sorting and thresholding so large equal float32/float64 inputs retain unit mass rather than producing all zeros. Integer inputs retain their existing path. This does not change sparse-projection handling or validation for nonpositive simplex radii.

Validation

Current head 1cc4127 includes master f48a63a. Only RELEASES.md conflicted; both release entries are retained. The PR production and regression files are byte-for-byte unchanged from its previous head.

  • Complete utility module and doctests: NumPy 127 passed, 1 skipped; NumPy/PyTorch 2.9.1 CPU 193 passed, 1 skipped; NumPy/TensorFlow 161 passed, 33 skipped. Each process asserts the actual backend list and source checkout. Torch and TensorFlow run in separate environments. Skips are reported, not counted as passes.

  • The updated master's native extensions were rebuilt locally with the existing MSVC/Cython toolchain; the results above were repeated against that build. No native solver correctness or performance claim follows from the utility tests.

  • All applicable configured pre-commit hooks for the PR files and diff checks pass.

  • A private integration of [MRG] Fix sparse simplex projection with oversized budgets #876, [MRG] Handle both endpoints in sample-ratio splitting #878 and [MRG] Stabilize simplex projection against large common offsets #880 on the same master passes the utility module/doctests: NumPy 145 passed, 1 skipped; NumPy/PyTorch 229 passed, 1 skipped; NumPy/TensorFlow 197 passed, 33 skipped. That local integration branch is not published and is not part of this PR.

Windows/Python 3.12.14, CPU only. The full package suite, current full documentation/gallery, GPU, JAX and CuPy were not run locally. Current-head CircleCI documentation build 4314 completed successfully, with its commit verified against this PR head; all three reported checks now pass. This is an upstream full documentation build, not a local gallery run.

Contribution disclosure

Prepared, investigated and tested autonomously by OpenAI Codex on behalf of AHMETHAKANBEZIR1. No independent human review has been performed.

15 November 2026 update (dbe2d6c). Merged master 3367480 and resolved the RELEASES.md conflict by keeping both entries. The PR's implementation and regression tests are unchanged. The utility and circle-solver test modules passed on Windows CPU (144 NumPy tests and 221 NumPy/PyTorch tests). The new CircleCI documentation checks are pending at the time of this update.

Co-authored-by: Codex <noreply@openai.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proj_simplex loses the simplex mass with large common floating-point offsets

1 participant