Add C API constructors for classical expressions - #16671
Conversation
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
I believe this, and the 4 others opened concurrently, to be an entirely LLM-generated PR with little human oversight, which is against the contribution guide. Given past experience, it is unlikely to be worth maintainer time to review. If you wish to meaningfully contribute, slow down, keep one or two PRs open max, and engage as a human, even if you use LLM assistance. |
Fixes #16667.
Summary
QkVar,QkStretch,QkValue, andQkExprNodeobjectsThis ports the useful API shape from the older WIP #16180 onto current
main, while leaving big-integer value construction for follow-up after #16666 lands.Verification
cargo check -p qiskit-cextmake ctestcargo run --quiet -p qiskit-bindgen-cli -- check-abi capi_slots.txtcargo check -p qiskit-cext-vtable --features addrcargo fmt --check --package qiskit-cext --package qiskit-cext-vtablegit diff --check