longprices.xls + chapter_3.xlsx: record the repoint (hold until the lecture PRs merge) - #43
Conversation
Held as a draft: must not merge before QuantEcon/lecture-python-intro#824 and QuantEcon/lecture-wasm#53. Verified both ways -- against the lecture repos' current main this fails with "marked repointed but consumers still read via ['own-repo', 'sibling']" for both files; against their repoint branches it passes clean and orphans fall 34 -> 32 as wasm's two mirror copies go. Set 2 of three. Unlike set 1 this batch had a reference the audit cannot see: a {download} directive in each repo offering chapter_3.xlsx to readers, pointing at the file being deleted. The lecture PRs move those too. The general problem -- ten such prose references across the remaining migration, none visible to the scan -- is #42. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Corrected: the orphan arithmetic changed when set 2 went two-phaseThis PR's description says orphans fall 34 → 32. That was true of the original single-phase shape and is no longer right. QuantEcon/lecture-python-intro#824 has been restructured to phase 1: repoint the URLs, keep the files. The reason is a failure mode the repoint rules did not cover: So the orphan path is now four steps rather than two:
Verified by simulation against the restructured branches: with both lecture halves merged this PR passes strict at exit 0 with 34 orphans, and intro's two kept files appear correctly as Also worth recording:
|
Green — the earlier failure was a stale run, not a real oneQuantEcon/lecture-python-intro#824 merged at 07:26:22; this PR's failing check ran at 06:09:56, seventy-six minutes earlier. It failed with exactly the pre-merge condition it should have — Re-run with no change to the branch: both checks pass, orphans 34, This is the third time the pattern has appeared and it is structural rather than bad luck: the tracker PR is always pushed before its lecture halves merge, so its first CI run necessarily evaluates a world in which the repoint has not happened. Expect it on every remaining set — a red check on a tracker PR should be read against the merge time of its lecture PRs before being treated as a finding. A re-run is the whole fix. Marked ready. Merging this takes Set 2 is then functionally complete: both lectures read data-lectures, the tracker is accurate, nothing is broken. The only outstanding piece is the phase-2 deletion of intro's two now-orphaned copies, which is deliberately gated on the next publish (repoint rule 3, #44) and deferred to the next session. |
There was a problem hiding this comment.
Pull request overview
Records the completion of repoint set A2 for the two inflation-history datasets by updating the migration tracker, manifests, and the generated catalog so the repo’s audit/dashboard reflects that lectures now consume longprices.xls and chapter_3.xlsx from data-lectures.
Changes:
- Flip
longprices.xlsandchapter_3.xlsxtostatus: repointedinmigration.yml, recording the two consuming lecture PRs. - Populate
consumersin each dataset’s sidecar manifest forlecture-python-introandlecture-wasm. - Regenerate
CATALOG.mdso the “Used by” column and summary counts reflect the new consumers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| migration.yml | Marks longprices.xls and chapter_3.xlsx as repointed and records the consuming lecture PRs/dates. |
| lectures/longprices.xls.yml | Adds the consuming lectures to the dataset manifest’s consumers list. |
| lectures/chapter_3.xlsx.yml | Adds the consuming lectures to the dataset manifest’s consumers list. |
| CATALOG.md | Updates the generated catalog to show these datasets are now used by inflation_history.md in both lecture repos. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Draft on purpose — do not merge before QuantEcon/lecture-python-intro#824 and QuantEcon/lecture-wasm#53.
Set 2 of three for the intro statics. Flips both datasets to
repointedand records the two consuming lectures in each manifest.main(PRs unmerged)marked repointed but consumers still read via ['own-repo', 'sibling']repoint/inflation-historybranchesWhat was different about this set
Set 1 was one line per repo. This one was three references per repo, and the third is the one worth knowing about: a
{download}directive offeringchapter_3.xlsxto readers, in both repos, pointing at the file being deleted.The audit cannot see it.
build_audit.pyclassifies data references by the code that reads them, so a prose link is invisible; and a dead{download}fails no lecture build, so neither repo's CI catches it either. Repointing the code alone would have left a 404 in a published page with this tracker recordingrepointedand every check green.Ten such references exist across the remaining migration — six more in
french_rev(set 3) and two insimple_linear_regression(wave 4). Inventoried in #42.The wasm side also carried its three references in two different URL forms (
raw.githubusercontent.comfor the reads,github.com/…/raw/for the download), so a single find-and-replace would have missed one.Part of #8 and #4.