Skip to content

🌐 [translation-sync] french_rev: read the five datasets from data-lectures - #288

Merged
mmcky merged 2 commits into
mainfrom
translation-sync-2026-08-06T23-47-41-pr-826
Aug 7, 2026
Merged

🌐 [translation-sync] french_rev: read the five datasets from data-lectures#288
mmcky merged 2 commits into
mainfrom
translation-sync-2026-08-06T23-47-41-pr-826

Conversation

@mmcky

@mmcky mmcky commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-intro.

Source PR

#826 - french_rev: read the five datasets from data-lectures

Files Updated

  • ✏️ lectures/french_rev.md
  • ✏️ .translate/state/french_rev.md.yml

Details

  • Source Language: en
  • Target Language: zh-cn
  • Model: claude-sonnet-5

This PR was created automatically by the translation action.

@mmcky
mmcky requested a lite review from Copilot August 6, 2026 23:47
@mmcky mmcky added action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation labels Aug 6, 2026
@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for playful-platypus-17d3bb ready!

Name Link
🔨 Latest commit 7d7faf0
🔍 Latest deploy log https://app.netlify.com/projects/playful-platypus-17d3bb/deploys/6a751d225c88460008810cc9
😎 Deploy Preview https://deploy-preview-288--playful-platypus-17d3bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

✅ Translation Quality Review

Verdict: PASS | Model: claude-sonnet-5 | Date: 2026-08-06
Routing: editor — 3 minor finding(s) in gating categories (accuracy/terminology/syntax/diff-check/other); accuracy 8 below floor 9; terminology 8 below floor 9
Shadow gate: would NOT auto-merge (recorded only; no action taken)


📝 Translation Quality

Criterion Score
Accuracy 8/10
Fluency 8/10
Terminology 8/10
Formatting 9/10
Overall 8.2/10

Summary: The translation of the modified sections (frontmatter, Data Sources, Remaking the tax code and tax administration) is accurate and fluent overall, with correct MyST formatting and appropriate terminology usage consistent with the glossary. Minor issues include an ASCII colon in place of a full-width Chinese colon, a slightly altered list nesting structure in the Overview bullets, an unexplained external hyperlink addition for 'assignats', and a couple of small fluency/emphasis shifts that do not affect overall meaning. No blocking or major accuracy issues were found in the changed sections. Faithfully preserves all code cells, figure captions, and MyST directive syntax without introducing syntax errors Consistent and accurate rendering of core technical/economic terminology (e.g., 税收平滑模型, 不愉快的货币主义算术, 真实票据理论) in line with the glossary Successfully conveys the complex historical and economic narrative of the Data Sources and Remaking the tax code sections with good readability

Suggestions:

  • [minor · accuracy] lectures/french_rev.md — Overview: '为了筹资公共开支和偿还债务,法国政府实验一系列政策。': The verb '实验' is used intransitively/awkwardly where the source says the government 'embarked on policy experiments.' It should be phrased as a verb-object structure to read naturally, e.g., '开展/进行了一系列政策实验'. → 为了筹资公共开支和偿还债务,法国政府开展了一系列政策实验。
  • [minor · terminology] lectures/french_rev.md — Overview: bullet on real bills theory: The source term 'assignats' is rendered with an added inline link to Baidu Baike (指券(assignats)) that does not exist in the English source. While the added gloss is helpful, inserting an external non-QuantEcon link is an unexplained addition not present in the source document and may be viewed as out-of-scope content insertion for this changed section. → Consider using a plain bolded term '指券(assignats)' without the external hyperlink, consistent with how other terms in the lecture are handled.
  • [minor · fluency] lectures/french_rev.md — Overview: '他们所依据的一些理论至今仍然具有重要意义:': A half-width colon ':' is used instead of the full-width Chinese colon ':', violating the punctuation policy for prose text. → 他们所依据的一些理论至今仍然具有重要意义:
  • [minor · terminology] lectures/french_rev.md — Overview: 'a tax-smoothing model' bullet paragraph: The nested bullet under 'tax-smoothing model' loses its indentation/list marker structure compared to the source (it appears as a separate top-level paragraph rather than a nested bullet, e.g., '* 这种规范性...' without proper indentation), slightly altering the list hierarchy visible in the English source. → Preserve the original nested bullet indentation for sub-points under each top-level theory, matching the source Markdown list structure.
  • [nit · fluency] lectures/french_rev.md — Remaking the tax code and tax administration: '这种支出超过收入的情况在法国支持美国独立战争期间及之后尤为严重': This is a reasonable paraphrase of the source sentence about growing debt service after the American War of Independence, but it merges/reorders the original two clauses (debt service growth vs. war expenditures) in a way that slightly softens the causal link to 'growing government debt service' as the explicit contributor mentioned in the English text. → 在法国支持美国独立战争的支出及之后,不断增长的政府偿债支出(即利息支付)加剧了这一状况。

🔍 Diff Quality

Check Status
Scope Correct
Position Correct
Structure Preserved
Heading-map Correct
Overall 10/10

Summary: The translation sync correctly mirrors all source changes (jupytext version bump, data URLs, imports, and npy loading via requests/BytesIO) in the same relative positions without altering document structure or headings.

Issues:

  • Minor: an extra blank line between '# 法国大革命期间的通货膨胀' and '## 概览' was removed in the target's After version, which is a trivial whitespace difference not present in the source diff, but does not affect structure or rendering.

This review was generated automatically by action-translation review mode.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This automated translation-sync PR updates the Chinese french_rev lecture to align with the upstream change of sourcing datasets from the QuantEcon/data-lectures repository, and refreshes the translation sync state metadata.

Changes:

  • Update dataset links and runtime URLs to load the lecture’s five datasets from QuantEcon/data-lectures.
  • Add runtime downloading for the two .npy datasets via requests + BytesIO.
  • Update translation sync state metadata (source-sha, synced-at, mode, tool-version).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lectures/french_rev.md Switch dataset references/URLs to data-lectures and update .npy loading to download from GitHub raw URLs.
.translate/state/french_rev.md.yml Update translation-sync state to the new upstream source SHA/date and tool/mode metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lectures/french_rev.md
Comment on lines +671 to +674
caron_response = requests.get(f'{base_url}caron.npy')
nom_balances_response = requests.get(f'{base_url}nom_balances.npy')
caron = np.load(BytesIO(caron_response.content))
nom_balances = np.load(BytesIO(nom_balances_response.content))
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

@github-actions
github-actions Bot temporarily deployed to pull request August 6, 2026 23:53 Inactive
@mmcky
mmcky merged commit 28bcc2a into main Aug 7, 2026
10 of 11 checks passed
@mmcky
mmcky deleted the translation-sync-2026-08-06T23-47-41-pr-826 branch August 7, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action-translation PRs created by QuantEcon/action-translation automated Automated sync PR opened by action-translation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants