🌐 [translation-sync] french_rev: read the five datasets from data-lectures - #288
Conversation
✅ Deploy Preview for playful-platypus-17d3bb ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Translation Quality ReviewVerdict: PASS | Model: claude-sonnet-5 | Date: 2026-08-06 📝 Translation Quality
Summary: The translation of the modified sections (frontmatter, Data Sources, Remaking the tax code and tax administration) is accurate and fluent overall, with correct MyST formatting and appropriate terminology usage consistent with the glossary. Minor issues include an ASCII colon in place of a full-width Chinese colon, a slightly altered list nesting structure in the Overview bullets, an unexplained external hyperlink addition for 'assignats', and a couple of small fluency/emphasis shifts that do not affect overall meaning. No blocking or major accuracy issues were found in the changed sections. Faithfully preserves all code cells, figure captions, and MyST directive syntax without introducing syntax errors Consistent and accurate rendering of core technical/economic terminology (e.g., 税收平滑模型, 不愉快的货币主义算术, 真实票据理论) in line with the glossary Successfully conveys the complex historical and economic narrative of the Data Sources and Remaking the tax code sections with good readability Suggestions:
🔍 Diff Quality
Summary: The translation sync correctly mirrors all source changes (jupytext version bump, data URLs, imports, and npy loading via requests/BytesIO) in the same relative positions without altering document structure or headings. Issues:
This review was generated automatically by action-translation review mode. |
There was a problem hiding this comment.
Pull request overview
This automated translation-sync PR updates the Chinese french_rev lecture to align with the upstream change of sourcing datasets from the QuantEcon/data-lectures repository, and refreshes the translation sync state metadata.
Changes:
- Update dataset links and runtime URLs to load the lecture’s five datasets from
QuantEcon/data-lectures. - Add runtime downloading for the two
.npydatasets viarequests+BytesIO. - Update translation sync state metadata (
source-sha,synced-at, mode, tool-version).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lectures/french_rev.md | Switch dataset references/URLs to data-lectures and update .npy loading to download from GitHub raw URLs. |
| .translate/state/french_rev.md.yml | Update translation-sync state to the new upstream source SHA/date and tool/mode metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| caron_response = requests.get(f'{base_url}caron.npy') | ||
| nom_balances_response = requests.get(f'{base_url}nom_balances.npy') | ||
| caron = np.load(BytesIO(caron_response.content)) | ||
| nom_balances = np.load(BytesIO(nom_balances_response.content)) |
Automated Translation Sync
This PR contains automated translations from QuantEcon/lecture-python-intro.
Source PR
#826 - french_rev: read the five datasets from data-lectures
Files Updated
lectures/french_rev.md.translate/state/french_rev.md.ymlDetails
This PR was created automatically by the translation action.